Page MenuHomePhabricator

[MIPS][MicroMIPS] Fix the definition of MOVEP instruction
ClosedPublic

Authored by milena.vujosevic.janicic on Sep 13 2018, 7:53 AM.

Details

Summary

The patch fixes definition of MOVEP instruction. Two registers are used instead of register pairs.
This is necessary as machine verifier cannot handle register pairs.

Diff Detail

Repository
rL LLVM

Event Timeline

Could that be tested somehow?

Could that be tested somehow?

Definition of MOVEP is changed but all the previously written test cases pass, so this change is tested by these old tests.

Problems with the old definition cannot be seen without code in D52037. Generating MOVEP from MicroMipsSizeReduce pass would fail with machine verifier error if this definition is not fixed.
(This is similar to the changes done for LWP/SWP instructions D47255 and D39115).

atanasyan accepted this revision.Sep 19 2018, 11:47 AM

LGTM. Thanks for the patch.

This revision is now accepted and ready to land.Sep 19 2018, 11:47 AM
This revision was automatically updated to reflect the committed changes.