Page MenuHomePhabricator

[mips] Fix the definitions of lwp, swp
ClosedPublic

Authored by sdardis on May 23 2018, 5:55 AM.

Details

Summary

Rather than using a regpair operand of these instructions, use two seperate
operands and a custom converter to handle the implicit second register operand.

Additionally, remove the microMIPS32R6 definition as its redundant.

Diff Detail

Repository
rL LLVM

Event Timeline

sdardis created this revision.May 23 2018, 5:55 AM
atanasyan accepted this revision.May 23 2018, 7:53 AM

LGTM with a nit.

lib/Target/Mips/AsmParser/MipsAsmParser.cpp
5532 ↗(On Diff #148196)

Redundant return.

This revision is now accepted and ready to land.May 23 2018, 7:53 AM
This revision was automatically updated to reflect the committed changes.

Maybe consider removing

parseRegisterPair, isRegPair, printRegisterPair and getRegisterPairOpValue

(It looks like these are not used any more?)