This is an archive of the discontinued LLVM Phabricator instance.

Differential D52022

[AMDGPU] Removed unused method
ClosedPublic

Authored by tpr on Sep 13 2018, 3:36 AM.

Details

Reviewers
nhaehnle
mareko
Commits
rGc8af6a46fa5e: [AMDGPU] Removed unused method
rL342189: [AMDGPU] Removed unused method
Summary

I accidentally left this behind in D50306, and it causes a build warning
when I build with gcc7.

Change-Id: I30f7a47047e9d9d841f652da66d2fea19e74842c

Diff Detail

Event Timeline

tpr created this revision.Sep 13 2018, 3:36 AM
Herald added subscribers: llvm-commits, t-tye, dstuttard and 6 others. · View Herald TranscriptSep 13 2018, 3:36 AM
Harbormaster completed remote builds in B22587: Diff 165244.Sep 13 2018, 3:37 AM
tpr added reviewers: nhaehnle, mareko.Sep 13 2018, 3:38 AM
nhaehnle accepted this revision.Sep 13 2018, 3:45 AM

LGTM

This revision is now accepted and ready to land.Sep 13 2018, 3:45 AM
Closed by commit rL342189: [AMDGPU] Removed unused method (authored by tpr). · Explain WhySep 13 2018, 2:59 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents

PathSize
lib/
Target/
AMDGPU/
22 lines

Diff 165244

lib/Target/AMDGPU/AMDGPUISelDAGToDAG.cpp

Show First 20 Lines • Show All 135 Lines • ▼ Show 20 Linesprivate:
bool SelectMUBUFOffset(SDValue Addr, SDValue &SRsrc, SDValue &SOffset, bool SelectMUBUFOffset(SDValue Addr, SDValue &SRsrc, SDValue &SOffset,
SDValue &Offset, SDValue &GLC, SDValue &SLC, SDValue &Offset, SDValue &GLC, SDValue &SLC,
SDValue &TFE) const; SDValue &TFE) const;
bool SelectMUBUFOffset(SDValue Addr, SDValue &SRsrc, SDValue &Soffset, bool SelectMUBUFOffset(SDValue Addr, SDValue &SRsrc, SDValue &Soffset,
SDValue &Offset, SDValue &SLC) const; SDValue &Offset, SDValue &SLC) const;
bool SelectMUBUFOffset(SDValue Addr, SDValue &SRsrc, SDValue &Soffset, bool SelectMUBUFOffset(SDValue Addr, SDValue &SRsrc, SDValue &Soffset,
SDValue &Offset) const; SDValue &Offset) const;
bool SelectMUBUFConstant(SDValue Constant,
SDValue &SOffset,
SDValue &ImmOffset) const;
bool SelectFlatAtomic(SDValue Addr, SDValue &VAddr, bool SelectFlatAtomic(SDValue Addr, SDValue &VAddr,
SDValue &Offset, SDValue &SLC) const; SDValue &Offset, SDValue &SLC) const;
bool SelectFlatAtomicSigned(SDValue Addr, SDValue &VAddr, bool SelectFlatAtomicSigned(SDValue Addr, SDValue &VAddr,
SDValue &Offset, SDValue &SLC) const; SDValue &Offset, SDValue &SLC) const;
template <bool IsSigned> template <bool IsSigned>
bool SelectFlatOffset(SDValue Addr, SDValue &VAddr, bool SelectFlatOffset(SDValue Addr, SDValue &VAddr,
▲ Show 20 Lines • Show All 1,121 Lines • ▼ Show 20 Lines
bool AMDGPUDAGToDAGISel::SelectMUBUFOffset(SDValue Addr, SDValue &SRsrc, bool AMDGPUDAGToDAGISel::SelectMUBUFOffset(SDValue Addr, SDValue &SRsrc,
SDValue &Soffset, SDValue &Offset, SDValue &Soffset, SDValue &Offset,
SDValue &SLC) const { SDValue &SLC) const {
SDValue GLC, TFE; SDValue GLC, TFE;
return SelectMUBUFOffset(Addr, SRsrc, Soffset, Offset, GLC, SLC, TFE); return SelectMUBUFOffset(Addr, SRsrc, Soffset, Offset, GLC, SLC, TFE);
} }
bool AMDGPUDAGToDAGISel::SelectMUBUFConstant(SDValue Constant,
SDValue &SOffset,
SDValue &ImmOffset) const {
SDLoc DL(Constant);
uint32_t Imm = cast<ConstantSDNode>(Constant)->getZExtValue();
uint32_t Overflow;
if (!AMDGPU::splitMUBUFOffset(Imm, Overflow, Imm, Subtarget))
return false;
ImmOffset = CurDAG->getTargetConstant(Imm, DL, MVT::i16);
if (Overflow <= 64)
SOffset = CurDAG->getTargetConstant(Overflow, DL, MVT::i32);
else
SOffset = SDValue(CurDAG->getMachineNode(AMDGPU::S_MOV_B32, DL, MVT::i32,
CurDAG->getTargetConstant(Overflow, DL, MVT::i32)),
0);
return true;
}
template <bool IsSigned> template <bool IsSigned>
bool AMDGPUDAGToDAGISel::SelectFlatOffset(SDValue Addr, bool AMDGPUDAGToDAGISel::SelectFlatOffset(SDValue Addr,
SDValue &VAddr, SDValue &VAddr,
SDValue &Offset, SDValue &Offset,
SDValue &SLC) const { SDValue &SLC) const {
int64_t OffsetVal = 0; int64_t OffsetVal = 0;
if (Subtarget->hasFlatInstOffsets() && if (Subtarget->hasFlatInstOffsets() &&
▲ Show 20 Lines • Show All 985 Lines • Show Last 20 Lines