This is an archive of the discontinued LLVM Phabricator instance.

Differential D51959

Add compatability version to liblldb in framework builds
ClosedPublic

Authored by xiaobai on Sep 11 2018, 4:35 PM.

Details

Reviewers
clayborg
labath
Commits
rGaad4027dc3b6: Add compatibility version to liblldb in framework builds
rLLDB342066: Add compatibility version to liblldb in framework builds
rL342066: Add compatibility version to liblldb in framework builds
Summary

Building LLDB with xcodebuild sets the compatability version of liblldb
in LLDB.framework. Building the framework with cmake does not set the
compatability version, and so it defaults to 0.0.0. This is a discrepency in the
difference between the xcode build and the cmake build.

I tested this change by building without this patch. From the build tree I ran
otool -L Library/Frameworks/LLDB.framework/Versions/A/LLDB and got this:

@rpath/LLDB.framework/Versions/A/LLDB (compatibility version 0.0.0, current version 8.0.0)

Did the same with this patch and the output contained this:

@rpath/LLDB.framework/Versions/A/LLDB (compatibility version 1.0.0, current version 8.0.0)

Diff Detail

Event Timeline

xiaobai created this revision.Sep 11 2018, 4:35 PM
Herald added a subscriber: mgorny. · View Herald TranscriptSep 11 2018, 4:35 PM
Harbormaster completed remote builds in B22511: Diff 164998.Sep 11 2018, 4:36 PM
teemperor added a subscriber: teemperor.Sep 11 2018, 10:45 PM

Nitpick: compatAbility->compatIbility

LGTM otherwise, but don’t know frameworks good enough to accept.

labath accepted this revision.Sep 12 2018, 1:23 AM

lgtm modulo typos

This revision is now accepted and ready to land.Sep 12 2018, 1:23 AM
clayborg accepted this revision.Sep 12 2018, 7:33 AM
xiaobai updated this revision to Diff 165126.Sep 12 2018, 11:06 AM

Fix typo (Thanks for the catch!)

Harbormaster completed remote builds in B22560: Diff 165126.Sep 12 2018, 11:06 AM
Closed by commit rL342066: Add compatibility version to liblldb in framework builds (authored by xiaobai). · Explain WhySep 12 2018, 11:12 AM
This revision was automatically updated to reflect the committed changes.
Herald added a subscriber: llvm-commits. · View Herald TranscriptSep 12 2018, 11:12 AM

Revision Contents

PathSize
source/
API/
1 line

Diff 165126

source/API/CMakeLists.txt

Show First 20 Lines • Show All 140 Lines • ▼ Show 20 Lines set_target_properties(liblldb
PROPERTIES PROPERTIES
OUTPUT_NAME lldb OUTPUT_NAME lldb
) )
endif() endif()
if (LLDB_BUILD_FRAMEWORK) if (LLDB_BUILD_FRAMEWORK)
set_target_properties(liblldb set_target_properties(liblldb
PROPERTIES PROPERTIES
SOVERSION "1.0.0"
OUTPUT_NAME LLDB OUTPUT_NAME LLDB
FRAMEWORK On FRAMEWORK On
FRAMEWORK_VERSION ${LLDB_FRAMEWORK_VERSION} FRAMEWORK_VERSION ${LLDB_FRAMEWORK_VERSION}
MACOSX_FRAMEWORK_INFO_PLIST ${LLDB_SOURCE_DIR}/resources/LLDB-Info.plist MACOSX_FRAMEWORK_INFO_PLIST ${LLDB_SOURCE_DIR}/resources/LLDB-Info.plist
LIBRARY_OUTPUT_DIRECTORY ${LLDB_FRAMEWORK_DIR} LIBRARY_OUTPUT_DIRECTORY ${LLDB_FRAMEWORK_DIR}
) )
endif() endif()
if (LLDB_WRAP_PYTHON) if (LLDB_WRAP_PYTHON)
add_dependencies(liblldb swig_wrapper) add_dependencies(liblldb swig_wrapper)
endif() endif()