Page MenuHomePhabricator

Add compatability version to liblldb in framework builds
ClosedPublic

Authored by xiaobai on Sep 11 2018, 4:35 PM.

Details

Summary

Building LLDB with xcodebuild sets the compatability version of liblldb
in LLDB.framework. Building the framework with cmake does not set the
compatability version, and so it defaults to 0.0.0. This is a discrepency in the
difference between the xcode build and the cmake build.

I tested this change by building without this patch. From the build tree I ran
otool -L Library/Frameworks/LLDB.framework/Versions/A/LLDB and got this:

@rpath/LLDB.framework/Versions/A/LLDB (compatibility version 0.0.0, current version 8.0.0)

Did the same with this patch and the output contained this:

@rpath/LLDB.framework/Versions/A/LLDB (compatibility version 1.0.0, current version 8.0.0)

Diff Detail

Repository
rL LLVM

Event Timeline

xiaobai created this revision.Sep 11 2018, 4:35 PM

Nitpick: compatAbility->compatIbility

LGTM otherwise, but don’t know frameworks good enough to accept.

labath accepted this revision.Sep 12 2018, 1:23 AM

lgtm modulo typos

This revision is now accepted and ready to land.Sep 12 2018, 1:23 AM
clayborg accepted this revision.Sep 12 2018, 7:33 AM
xiaobai updated this revision to Diff 165126.Sep 12 2018, 11:06 AM

Fix typo (Thanks for the catch!)

This revision was automatically updated to reflect the committed changes.