This is an archive of the discontinued LLVM Phabricator instance.

AMDGPU: Print all kernel descriptor directives (including the ones with default values)
ClosedPublic

Authored by kzhuravl on Sep 11 2018, 3:24 PM.

Diff Detail

Event Timeline

kzhuravl created this revision.Sep 11 2018, 3:24 PM

LGTM, but adding Matt because I think he was the one to originally request eliding defaulted fields. From what Tony described I agree we can't do this generally because of options which depend on attributes, e.g. -mattr=+/-xnack changes the "default".

This revision was not accepted when it landed; it landed in state Needs Review.Sep 12 2018, 1:27 PM
This revision was automatically updated to reflect the committed changes.