This is an archive of the discontinued LLVM Phabricator instance.

Differential D51681

[Msan] Fix unit test linkage issue on FreeBSD
ClosedPublic

Authored by devnexen on Sep 5 2018, 5:45 AM.

Details

Reviewers
dim
emaste
Commits
rG395aa789869c: [Msan] Fix unit test linkage issue on FreeBSD
rCRT341924: [Msan] Fix unit test linkage issue on FreeBSD
rL341924: [Msan] Fix unit test linkage issue on FreeBSD
Summary

Fix typical relocation linkage issue.

Diff Detail

Repository
rL LLVM

Event Timeline

devnexen created this revision.Sep 5 2018, 5:45 AM
Herald added subscribers: Restricted Project, llvm-commits. · View Herald TranscriptSep 5 2018, 5:45 AM
devnexen added a reviewer: krytarowski.Sep 5 2018, 5:46 AM
krytarowski added a comment.Sep 5 2018, 5:50 AM

What's the error message?

devnexen added a comment.EditedSep 5 2018, 5:56 AM
... /tmp/lit_tmp_Dmkg99/tls_reuse-067934.o: relocation R_X86_64_TPOFF32 against `x' can not be used when making a shared object...
krytarowski added a comment.Sep 5 2018, 5:57 AM

In general -fPIC is probably the way to go.. but I don't know about this particular case. I defer decision to FreeBSD maintainers.

krytarowski resigned from this revision.Sep 5 2018, 6:10 AM
devnexen edited reviewers, added: dim, emaste; removed: krytarowski.Sep 5 2018, 6:13 AM
This revision was not accepted when it landed; it landed in state Needs Review.Sep 11 2018, 3:37 AM
Closed by commit rL341924: [Msan] Fix unit test linkage issue on FreeBSD (authored by devnexen). · Explain Why
This revision was automatically updated to reflect the committed changes.
Herald added a subscriber: delcypher. · View Herald TranscriptSep 11 2018, 3:37 AM

Revision Contents

PathSize
compiler-rt/
trunk/
test/
msan/
2 lines

Diff 164842

compiler-rt/trunk/test/msan/lit.cfg

Show All 11 Lines
clang_msan_cflags = (["-fsanitize=memory", clang_msan_cflags = (["-fsanitize=memory",
"-mno-omit-leaf-frame-pointer", "-mno-omit-leaf-frame-pointer",
"-fno-omit-frame-pointer", "-fno-omit-frame-pointer",
"-fno-optimize-sibling-calls"] + "-fno-optimize-sibling-calls"] +
[config.target_cflags] + [config.target_cflags] +
config.debug_info_flags) config.debug_info_flags)
# Some Msan tests leverage backtrace() which requires libexecinfo on FreeBSD. # Some Msan tests leverage backtrace() which requires libexecinfo on FreeBSD.
if config.host_os == 'FreeBSD': if config.host_os == 'FreeBSD':
clang_msan_cflags += ["-lexecinfo"] clang_msan_cflags += ["-lexecinfo", "-fPIC"]
clang_msan_cxxflags = config.cxx_mode_flags + clang_msan_cflags clang_msan_cxxflags = config.cxx_mode_flags + clang_msan_cflags
# Flags for KMSAN invocation. This is C-only, we're not interested in C++. # Flags for KMSAN invocation. This is C-only, we're not interested in C++.
clang_kmsan_cflags = (["-fsanitize=kernel-memory"] + clang_kmsan_cflags = (["-fsanitize=kernel-memory"] +
[config.target_cflags] + [config.target_cflags] +
config.debug_info_flags) config.debug_info_flags)
def build_invocation(compile_flags): def build_invocation(compile_flags):
Show All 19 Lines