This is an archive of the discontinued LLVM Phabricator instance.

Paths

[Msan] Fix unit test linkage issue on FreeBSD
ClosedPublic

Authored by devnexen on Sep 5 2018, 5:45 AM.

Reviewers

dim
emaste

Commits

Summary

Fix typical relocation linkage issue.

What's the error message?

... /tmp/lit_tmp_Dmkg99/tls_reuse-067934.o: relocation R_X86_64_TPOFF32 against `x' can not be used when making a shared object...

In general -fPIC is probably the way to go.. but I don't know about this particular case. I defer decision to FreeBSD maintainers.

This revision was not accepted when it landed; it landed in state Needs Review.Sep 11 2018, 3:37 AM

This revision was automatically updated to reflect the committed changes.

Path

Size

test/

msan/

2 lines

Context not available.
	config.debug_info_flags)	config.debug_info_flags)
	# Some Msan tests leverage backtrace() which requires libexecinfo on FreeBSD.	# Some Msan tests leverage backtrace() which requires libexecinfo on FreeBSD.
	if config.host_os == 'FreeBSD':	if config.host_os == 'FreeBSD':
	clang_msan_cflags += ["-lexecinfo"]	clang_msan_cflags += ["-lexecinfo", "-fPIC"]
	clang_msan_cxxflags = config.cxx_mode_flags + clang_msan_cflags	clang_msan_cxxflags = config.cxx_mode_flags + clang_msan_cflags

	def build_invocation(compile_flags):	def build_invocation(compile_flags):
Context not available.