This is an archive of the discontinued LLVM Phabricator instance.

[dwarfdump] Improve -diff option by hiding more.
ClosedPublic

Authored by JDevlieghere on Sep 3 2018, 6:27 AM.

Details

Summary

The -diff option makes it easy to diff dwarf by hiding addresses and offsets. However not all of them were hidden, which should be fixed by this patch.

Diff Detail

Repository
rL LLVM

Event Timeline

JDevlieghere created this revision.Sep 3 2018, 6:27 AM
aprantl accepted this revision.Sep 4 2018, 8:38 AM

Thanks, this will be very useful.

llvm/lib/DebugInfo/DWARF/DWARFFormValue.cpp
410

Can using two different streams cause the output to go out of sync due to buffering?

This revision is now accepted and ready to land.Sep 4 2018, 8:38 AM
JDevlieghere marked an inline comment as done.Sep 4 2018, 9:03 AM
JDevlieghere added inline comments.
llvm/lib/DebugInfo/DWARF/DWARFFormValue.cpp
410

It's either the same stream or null, so shouldn't pose a problem.

This revision was automatically updated to reflect the committed changes.
JDevlieghere marked an inline comment as done.