This is an archive of the discontinued LLVM Phabricator instance.

[mips][microMIPS] Implement ADDIUR1SP instruction
ClosedPublic

Authored by jkolek on Sep 2 2014, 7:03 AM.

Details

Summary

Implement 16-bit microMIPS instruction ADDIUR1SP.

Diff Detail

Event Timeline

jkolek updated this revision to Diff 13163.Sep 2 2014, 7:03 AM
jkolek retitled this revision from to [mips][microMIPS] Implement ADDIUR1SP instruction.
jkolek updated this object.
jkolek edited the test plan for this revision. (Show Details)
jkolek added reviewers: dsanders, vmedic.
jkolek added a subscriber: zoran.jovanovic.
jkolek updated this revision to Diff 13244.Sep 4 2014, 4:06 AM
jkolek updated this revision to Diff 13246.Sep 4 2014, 4:32 AM
jkolek updated this revision to Diff 14351.Oct 2 2014, 3:16 PM
jkolek updated this revision to Diff 14352.
jkolek added a reviewer: sstankovic.
sstankovic added inline comments.Oct 10 2014, 7:20 AM
lib/Target/Mips/AsmParser/MipsAsmParser.cpp
1225

You should also check that the operand is not greater than 255 or less than 0, and add a test that reports the error if it is.

jkolek updated this revision to Diff 14930.Oct 15 2014, 5:10 AM
sstankovic accepted this revision.Oct 21 2014, 7:27 AM
sstankovic edited edge metadata.
This revision is now accepted and ready to land.Oct 21 2014, 7:27 AM
Diffusion closed this revision.Oct 23 2014, 4:24 AM
Diffusion updated this revision to Diff 15316.

Closed by commit rL220477 (authored by zjovanovic).

jkolek edited edge metadata.Nov 18 2014, 5:59 AM
jkolek added a subscriber: Unknown Object (MLST).