This is an archive of the discontinued LLVM Phabricator instance.

Differential D51485

[Sema][NFC] Trivial cleanup in ActOnCallExpr
ClosedPublic

Authored by jkorous on Aug 30 2018, 4:47 AM.

Details

Reviewers
rsmith
doug.gregor
JDevlieghere
thegameg
Commits
rGba3334a25f8a: [Sema][NFC] Trivial cleanup in ActOnCallExpr
rC341074: [Sema][NFC] Trivial cleanup in ActOnCallExpr
rL341074: [Sema][NFC] Trivial cleanup in ActOnCallExpr
Summary

Use logical or operator instead of a bool variable and if/else.

Diff Detail

Repository
rC Clang

Event Timeline

jkorous created this revision.Aug 30 2018, 4:47 AM
Herald added subscribers: cfe-commits, dexonsmith. · View Herald TranscriptAug 30 2018, 4:47 AM
JDevlieghere accepted this revision.Aug 30 2018, 4:54 AM

Nice cleanup, LGTM.

This revision is now accepted and ready to land.Aug 30 2018, 4:54 AM
Closed by commit rL341074: [Sema][NFC] Trivial cleanup in ActOnCallExpr (authored by jkorous). · Explain WhyAug 30 2018, 7:47 AM
This revision was automatically updated to reflect the committed changes.
Herald added a subscriber: llvm-commits. · View Herald TranscriptAug 30 2018, 7:47 AM

Revision Contents

PathSize
lib/
Sema/
8 lines

Diff 163304

lib/Sema/SemaExpr.cpp

  • This file is larger than 256 KB, so syntax highlighting is disabled by default.
Show First 20 Lines • Show All 5,324 Lines • ▼ Show 20 Lines if (getLangOpts().CPlusPlus) {
if (Fn->getType() == Context.PseudoObjectTy) { if (Fn->getType() == Context.PseudoObjectTy) {
ExprResult result = CheckPlaceholderExpr(Fn); ExprResult result = CheckPlaceholderExpr(Fn);
if (result.isInvalid()) return ExprError(); if (result.isInvalid()) return ExprError();
Fn = result.get(); Fn = result.get();
} }
// Determine whether this is a dependent call inside a C++ template, // Determine whether this is a dependent call inside a C++ template,
// in which case we won't do any semantic analysis now. // in which case we won't do any semantic analysis now.
bool Dependent = false; if (Fn->isTypeDependent() || Expr::hasAnyTypeDependentArguments(ArgExprs)) {
if (Fn->isTypeDependent())
Dependent = true;
else if (Expr::hasAnyTypeDependentArguments(ArgExprs))
Dependent = true;
if (Dependent) {
if (ExecConfig) { if (ExecConfig) {
return new (Context) CUDAKernelCallExpr( return new (Context) CUDAKernelCallExpr(
Context, Fn, cast<CallExpr>(ExecConfig), ArgExprs, Context, Fn, cast<CallExpr>(ExecConfig), ArgExprs,
Context.DependentTy, VK_RValue, RParenLoc); Context.DependentTy, VK_RValue, RParenLoc);
} else { } else {
tryImplicitlyCaptureThisIfImplicitMemberFunctionAccessWithDependentArgs( tryImplicitlyCaptureThisIfImplicitMemberFunctionAccessWithDependentArgs(
*this, dyn_cast<UnresolvedMemberExpr>(Fn->IgnoreParens()), *this, dyn_cast<UnresolvedMemberExpr>(Fn->IgnoreParens()),
▲ Show 20 Lines • Show All 11,159 Lines • Show Last 20 Lines