Documentation can be found at https://www.khronos.org/registry/OpenCL/extensions/intel/cl_intel_device_side_avc_motion_estimation.txt
Patch by Kristina Bessonova
Paths
| Differential D51484
[OpenCL] Add support of cl_intel_device_side_avc_motion_estimation extension ClosedPublic Authored by AlexeySachkov on Aug 30 2018, 3:58 AM.
Details
Summary Documentation can be found at https://www.khronos.org/registry/OpenCL/extensions/intel/cl_intel_device_side_avc_motion_estimation.txt Patch by Kristina Bessonova
Diff Detail Event Timeline
AlexeySotkin added inline comments.
AlexeySachkov added inline comments.
Comment Actions It would be good to test your CIndex changes in test/Index/opencl-types.cl.
AlexeySachkov marked an inline comment as done. Comment ActionsUpdated tests. Reverted usage of #pragma OPENCL EXTENSION my_ext : begin due to a failed LIT tests: test/Headers/opencl-c-header.cl Test failed on the following RUN-line: // Compile for OpenCL 2.0 for the first time. The module should change. // RUN: %clang_cc1 -triple spir-unknown-unknown -O0 -emit-llvm -o - -cl-std=CL2.0 -finclude-default-header -fmodules -fimplicit-modu le-maps -fmodules-cache-path=%t -fdisable-module-hash -ftime-report %s 2>&1 | FileCheck --check-prefix=CHECK20 --check-prefix=CHECK- MOD %s Clang crashes at the assertion in ASTReader::getGlobalSubmoduleID(): assert(I != M.SubmoduleRemap.end() && "Invalid index into submodule index remap");
AlexeySachkov added inline comments.
Comment Actions LGTM! Thanks!
This revision is now accepted and ready to land.Oct 26 2018, 8:15 AM
Comment Actions Updated opencl-c.h header: fixed typos in built-in declarations. Applied comment from Alexey Closed by commit rL346326: [OpenCL] Add support of cl_intel_device_side_avc_motion_estimation extension (authored by asavonic). · Explain WhyNov 7 2018, 7:46 AM This revision was automatically updated to reflect the committed changes. Comment Actions I reverted this change in r346338, as it breaks Index/opencl-types.cl LIT test. See http://lab.llvm.org:8011/builders/clang-ppc64le-linux/builds/21503/steps/ninja%20check%201/logs/FAIL%3A%20Clang%3A%3Aopencl-types.cl
Revision Contents
Diff 173130 include/clang-c/Index.h
include/clang/AST/ASTContext.h
include/clang/AST/Type.h
include/clang/Basic/OpenCLExtensionTypes.def
include/clang/Basic/OpenCLExtensions.def
include/clang/Sema/Initialization.h
include/clang/Serialization/ASTBitCodes.h
include/clang/module.modulemap
lib/AST/ASTContext.cpp
lib/AST/ASTImporter.cpp
lib/AST/ExprConstant.cpp
lib/AST/ItaniumMangle.cpp
lib/AST/MicrosoftMangle.cpp
lib/AST/NSAPI.cpp
lib/AST/PrintfFormatString.cpp
lib/AST/Type.cpp
lib/AST/TypeLoc.cpp
lib/CodeGen/CGDebugInfo.h
lib/CodeGen/CGDebugInfo.cpp
lib/CodeGen/CGExprScalar.cpp
lib/CodeGen/CGOpenCLRuntime.cpp
lib/CodeGen/CodeGenTypes.cpp
lib/CodeGen/ItaniumCXXABI.cpp
lib/Headers/opencl-c.h
lib/Index/USRGeneration.cpp
lib/Sema/Sema.cpp
lib/Sema/SemaExpr.cpp
lib/Sema/SemaInit.cpp
lib/Serialization/ASTCommon.cpp
lib/Serialization/ASTReader.cpp
test/CodeGenOpenCL/intel-subgroups-avc-ext-types.cl
test/Headers/opencl-c-header.cl
test/Index/opencl-types.cl
test/SemaOpenCL/extension-version.cl
test/SemaOpenCL/intel-subgroup-avc-ext-types.cl
tools/libclang/CIndex.cpp
tools/libclang/CXType.cpp
|
I guess this define is not needed here.