Page MenuHomePhabricator

sidorovd (Dmitry Sidorov)
User

Projects

User does not belong to any projects.

User Details

User Since
Aug 3 2018, 2:20 AM (19 w, 3 d)

Recent Activity

Fri, Nov 30

sidorovd added inline comments to D54947: [OpenCL][CodeGen] Fix replacing memcpy with addrspacecast.
Fri, Nov 30, 4:19 AM
sidorovd updated the diff for D54947: [OpenCL][CodeGen] Fix replacing memcpy with addrspacecast.

Removed redundant lines in a comment

Fri, Nov 30, 4:19 AM

Wed, Nov 28

sidorovd added a comment to D54947: [OpenCL][CodeGen] Fix replacing memcpy with addrspacecast.

@yaxunl, since I'm partially reverting your change https://reviews.llvm.org/D34367 can you give a feedback on this?

Wed, Nov 28, 10:17 AM
sidorovd updated the diff for D54947: [OpenCL][CodeGen] Fix replacing memcpy with addrspacecast.
Wed, Nov 28, 10:17 AM

Tue, Nov 27

sidorovd created D54947: [OpenCL][CodeGen] Fix replacing memcpy with addrspacecast.
Tue, Nov 27, 5:34 AM

Nov 16 2018

sidorovd added a comment to D51341: [HEADER] Overloadable function candidates for half/double types.

@Anastasia @yaxunl
Hi, I am working on generalizing this patch and several questions have raised during this, so I want to discuss them with you:

  1. Should #pragma OPENCL EXTENSION ext_name : begin enables the extension as well? For now I see it's not, as an example:
Nov 16 2018, 5:52 AM

Oct 19 2018

sidorovd added a comment to D51402: [OpenCL] Adding cl_intel_planar_yuv extension.

Ping

Oct 19 2018, 12:17 AM

Oct 11 2018

sidorovd updated the diff for D51402: [OpenCL] Adding cl_intel_planar_yuv extension.
  • Forgot to add clarification comments on conditional branching. Added.
Oct 11 2018, 4:24 AM
sidorovd updated the diff for D51402: [OpenCL] Adding cl_intel_planar_yuv extension.

Moved the test to test/Headers/opencl-c-header.cl

Oct 11 2018, 4:20 AM

Oct 2 2018

sidorovd added a comment to D52658: [OpenCL] Remove PIPE_RESERVE_ID_VALID_BIT from opencl-c.h.

Does it mean we should close https://reviews.llvm.org/D32896?

Oct 2 2018, 10:35 AM
sidorovd added a comment to D51402: [OpenCL] Adding cl_intel_planar_yuv extension.

@Anastasia , since there is a problem I described, wouldn't you mind if I stay with the first iteration of the patch (adding the extension to OpenCLExtensions.def) and after we'll investigate what is wrong with -cl-ext approach?

Oct 2 2018, 9:25 AM

Oct 1 2018

sidorovd retitled D52658: [OpenCL] Remove PIPE_RESERVE_ID_VALID_BIT from opencl-c.h from [OpenCL] Remove PIPE_RESERVE_ID_VALID_BIT from the common header to [OpenCL] Remove PIPE_RESERVE_ID_VALID_BIT from opencl-c.h.
Oct 1 2018, 3:42 AM

Sep 28 2018

sidorovd created D52658: [OpenCL] Remove PIPE_RESERVE_ID_VALID_BIT from opencl-c.h.
Sep 28 2018, 9:18 AM

Sep 26 2018

sidorovd added inline comments to D51402: [OpenCL] Adding cl_intel_planar_yuv extension.
Sep 26 2018, 5:10 AM

Sep 21 2018

sidorovd updated the diff for D52292: [Sema][OpenCL] Improve diagnostics for not viable overloadable function candidates.

getOpenCLExtensionsFromTypeExtMap was added

Sep 21 2018, 2:50 AM

Sep 20 2018

sidorovd updated subscribers of D51402: [OpenCL] Adding cl_intel_planar_yuv extension.
Sep 20 2018, 5:39 AM
sidorovd added inline comments to D52292: [Sema][OpenCL] Improve diagnostics for not viable overloadable function candidates.
Sep 20 2018, 5:32 AM
sidorovd updated the diff for D52292: [Sema][OpenCL] Improve diagnostics for not viable overloadable function candidates.
Sep 20 2018, 5:32 AM
sidorovd created D52292: [Sema][OpenCL] Improve diagnostics for not viable overloadable function candidates.
Sep 20 2018, 2:35 AM

Sep 17 2018

sidorovd added a comment to D51341: [HEADER] Overloadable function candidates for half/double types.

For now this patch is on hold since it adds no new functionality. Its future will be decided after @asavonic finished https://reviews.llvm.org/D51544

Sep 17 2018, 4:18 AM

Sep 6 2018

sidorovd updated the diff for D51722: [OpenCL] Allow blocks to capture arrays in OpenCL.

Reference to the Spec was added

Sep 6 2018, 7:43 AM
sidorovd updated the diff for D51341: [HEADER] Overloadable function candidates for half/double types.
Sep 6 2018, 1:54 AM
sidorovd added inline comments to D51341: [HEADER] Overloadable function candidates for half/double types.
Sep 6 2018, 1:52 AM
sidorovd added a comment to D51722: [OpenCL] Allow blocks to capture arrays in OpenCL.

Previously this patch was reviewed here: https://reviews.llvm.org/D26794 . I wasn't able to update it, so I created a new one with the comments applied.

Sep 6 2018, 1:32 AM
sidorovd created D51722: [OpenCL] Allow blocks to capture arrays in OpenCL.
Sep 6 2018, 1:32 AM
sidorovd updated the diff for D51402: [OpenCL] Adding cl_intel_planar_yuv extension.

I'm not sure if I put pragmas in an appropriate place (I mean in the very beginning of the header).

Sep 6 2018, 1:08 AM

Aug 29 2018

sidorovd created D51402: [OpenCL] Adding cl_intel_planar_yuv extension.
Aug 29 2018, 12:08 AM

Aug 28 2018

sidorovd updated the diff for D51341: [HEADER] Overloadable function candidates for half/double types.
Aug 28 2018, 2:04 AM
sidorovd created D51341: [HEADER] Overloadable function candidates for half/double types.
Aug 28 2018, 1:57 AM

Aug 16 2018

sidorovd added a comment to D50240: [RuntimeDyld] Fix a calculation of common symbols size.

No, I don't have, commit it please.

Aug 16 2018, 2:13 PM
sidorovd added a comment to D50240: [RuntimeDyld] Fix a calculation of common symbols size.

Ping

Aug 16 2018, 1:50 AM

Aug 3 2018

sidorovd created D50240: [RuntimeDyld] Fix a calculation of common symbols size.
Aug 3 2018, 3:57 AM