Page MenuHomePhabricator

sidorovd (Dmitry Sidorov)
User

Projects

User does not belong to any projects.

User Details

User Since
Aug 3 2018, 2:20 AM (112 w, 2 d)

Recent Activity

Jul 29 2020

sidorovd updated the diff for D82174: [OpenCL] Add global_device and global_host address spaces.

Simplified the test

Jul 29 2020, 4:33 AM · Restricted Project

Jul 24 2020

sidorovd added inline comments to D82174: [OpenCL] Add global_device and global_host address spaces.
Jul 24 2020, 1:46 PM · Restricted Project
sidorovd updated the diff for D82174: [OpenCL] Add global_device and global_host address spaces.
Jul 24 2020, 1:45 PM · Restricted Project

Jul 15 2020

sidorovd added a comment to D82174: [OpenCL] Add global_device and global_host address spaces.

Sorry for a late response and thank you very much for the feedback!

Jul 15 2020, 6:28 AM · Restricted Project
sidorovd updated the diff for D82174: [OpenCL] Add global_device and global_host address spaces.
Jul 15 2020, 6:26 AM · Restricted Project

Jun 26 2020

sidorovd added inline comments to D82174: [OpenCL] Add global_device and global_host address spaces.
Jun 26 2020, 4:18 AM · Restricted Project

Jun 24 2020

sidorovd added a comment to D82174: [OpenCL] Add global_device and global_host address spaces.

TODO: update address space numerical values for SPIR target
Regarding the TODO. Still I like an idea of detached address spaces a little bit more, but I see your point. I would love to check how it works with SPIR-V address space mapping in SPIR-V to LLVM IR translator. I know, it shall have a little impact on a clang work, but still what to see the work I have to do there first (5 and 6 are already occupied there).

Makes sense. I think conversion to SPIR-V is one of the primary use cases. However, if checking doesn't need a lot of time it would be better to commit with the final numbering scheme. Otherwise things like this are pretty hard to change once they start to be used.

Jun 24 2020, 8:04 AM · Restricted Project
sidorovd updated the diff for D82174: [OpenCL] Add global_device and global_host address spaces.

Made SPIR AS map continuous.

Jun 24 2020, 7:31 AM · Restricted Project

Jun 23 2020

sidorovd updated the diff for D82174: [OpenCL] Add global_device and global_host address spaces.
Jun 23 2020, 1:59 PM · Restricted Project
sidorovd added inline comments to D82174: [OpenCL] Add global_device and global_host address spaces.
Jun 23 2020, 11:48 AM · Restricted Project
sidorovd added a comment to D82174: [OpenCL] Add global_device and global_host address spaces.

TODO: update address space numerical values for SPIR target
Regarding the TODO. Still I like an idea of detached address spaces a little bit more, but I see your point. I would love to check how it works with SPIR-V address space mapping in SPIR-V to LLVM IR translator. I know, it shall have a little impact on a clang work, but still what to see the work I have to do there first (5 and 6 are already occupied there).

Makes sense. I think conversion to SPIR-V is one of the primary use cases. However, if checking doesn't need a lot of time it would be better to commit with the final numbering scheme. Otherwise things like this are pretty hard to change once they start to be used.

Jun 23 2020, 11:15 AM · Restricted Project
sidorovd added inline comments to D82174: [OpenCL] Add global_device and global_host address spaces.
Jun 23 2020, 10:43 AM · Restricted Project
sidorovd updated the diff for D82174: [OpenCL] Add global_device and global_host address spaces.
Jun 23 2020, 10:43 AM · Restricted Project

Jun 22 2020

sidorovd added inline comments to D82174: [OpenCL] Add global_device and global_host address spaces.
Jun 22 2020, 7:30 AM · Restricted Project
sidorovd updated the diff for D82174: [OpenCL] Add global_device and global_host address spaces.

Uploaded the full diff. I have already forgot have to Phabricator properly :)

Jun 22 2020, 7:30 AM · Restricted Project
sidorovd updated the diff for D82174: [OpenCL] Add global_device and global_host address spaces.
Jun 22 2020, 7:30 AM · Restricted Project

Jun 19 2020

sidorovd added inline comments to D82174: [OpenCL] Add global_device and global_host address spaces.
Jun 19 2020, 8:05 AM · Restricted Project
sidorovd updated the summary of D82174: [OpenCL] Add global_device and global_host address spaces.
Jun 19 2020, 3:44 AM · Restricted Project
sidorovd created D82174: [OpenCL] Add global_device and global_host address spaces.
Jun 19 2020, 3:44 AM · Restricted Project
sidorovd updated the summary of D82174: [OpenCL] Add global_device and global_host address spaces.
Jun 19 2020, 3:44 AM · Restricted Project

Oct 28 2019

sidorovd added a reverting change for D61477: [ELF] -z combreloc: sort dynamic relocations by (symbol_index,r_offset): rZORGc34c3620d1f3: [ELF] -z combreloc: sort dynamic relocations by (!is_relative,symbol_index….
Oct 28 2019, 5:11 PM · Restricted Project
sidorovd added a reverting change for D53906: [ARM][AArch64] Increase TLS alignment to reserve space for Android's TCB: rZORG18bfb2b0f9fa: [ARM][AArch64] Revert Android Bionic PT_TLS overaligning hack.
Oct 28 2019, 5:10 PM · Restricted Project
sidorovd added a reverting change for D58632: [X86] Improve lowering of idemptotent RMW operations: rZORG2f84c3005f6f: [X86] Disable speculative load hardening for operations with an explicit RSP….
Oct 28 2019, 4:59 PM · Restricted Project
sidorovd added a reverting change for D58632: [X86] Improve lowering of idemptotent RMW operations: rZORGf62401d7d835: [X86] Disable speculative load hardening for operations with an explicit RSP….
Oct 28 2019, 4:42 PM · Restricted Project

Aug 28 2019

sidorovd added a comment to D66850: [AST][JSON] Avoid crash when dumping NULL Type as JSON.

LGTM. I'm not an expert in JSON, but may be it makes sense to move the change a line earlier before creation of pointer representation?

Aug 28 2019, 1:53 AM · Restricted Project

Jun 24 2019

vladimirlaz <vladimir.lazarev@intel.com> committed rGb343f8f70562: [SYCL] Fix metadata for Intel FPGA loop attributes (authored by sidorovd).
[SYCL] Fix metadata for Intel FPGA loop attributes
Jun 24 2019, 11:59 AM
sidorovd committed rGd6c48c35a1bd: Merge remote-tracking branch 'intel' into 'sycl' (authored by sidorovd).
Merge remote-tracking branch 'intel' into 'sycl'
Jun 24 2019, 11:59 AM
sidorovd committed rG854c81b03746: Merge branch 'master' into intel (authored by sidorovd).
Merge branch 'master' into intel
Jun 24 2019, 11:59 AM
sidorovd committed rG5949190e8d56: Merge branch 'master' into intel (authored by sidorovd).
Merge branch 'master' into intel
Jun 24 2019, 11:59 AM
sidorovd committed rG1db4a5d65dad: Merge branch 'master' into intel (authored by sidorovd).
Merge branch 'master' into intel
Jun 24 2019, 11:59 AM

May 30 2019

sidorovd committed rG537f92a2f59f: Fix for build and LIT failures after sync with LLVM eee5d425c1 (authored by sidorovd).
Fix for build and LIT failures after sync with LLVM eee5d425c1
May 30 2019, 11:09 AM
sidorovd committed rG8d4be776a84f: Sync to SPIRV-LLVM-Translator ed1a4f738d43 (authored by sidorovd).
Sync to SPIRV-LLVM-Translator ed1a4f738d43
May 30 2019, 11:09 AM
sidorovd committed rG9a81195849d3: [clangd-vscode] Bump versions dependencies. NFC (authored by ilya-biryukov).
[clangd-vscode] Bump versions dependencies. NFC
May 30 2019, 11:09 AM
sidorovd committed rGf15d712d6741: [ARM][CGP] Clear SafeWrap before each search (authored by samparker).
[ARM][CGP] Clear SafeWrap before each search
May 30 2019, 11:09 AM
sidorovd committed rG307ada67354c: Simplify `GetName`+`AppendTypeName` by `DWARFDIE` (authored by jankratochvil).
Simplify `GetName`+`AppendTypeName` by `DWARFDIE`
May 30 2019, 11:09 AM
sidorovd committed rG511aeea3f836: [CodeComplete] Complete a lambda when preferred type is a function (authored by ilya-biryukov).
[CodeComplete] Complete a lambda when preferred type is a function
May 30 2019, 11:09 AM
sidorovd committed rG9ad1f8e0907c: [GlobalOpt] recognize dead struct fields and propagate values (authored by chrib).
[GlobalOpt] recognize dead struct fields and propagate values
May 30 2019, 11:08 AM
sidorovd committed rG9d78e905c527: [Reproducer] Pass FileSpec by const-ref. (NFC) (authored by JDevlieghere).
[Reproducer] Pass FileSpec by const-ref. (NFC)
May 30 2019, 11:08 AM
sidorovd committed rG815eded6a218: [Utility] Modernize C-style cats (authored by JDevlieghere).
[Utility] Modernize C-style cats
May 30 2019, 11:08 AM
sidorovd committed rGd047a90292b0: [CMake][Fuchsia] Use cannonical triples for runtimes (authored by phosek).
[CMake][Fuchsia] Use cannonical triples for runtimes
May 30 2019, 11:08 AM
sidorovd committed rG84682ba34a9b: Remove unnecessary const&s; NFC (authored by george.burgess.iv).
Remove unnecessary const&s; NFC
May 30 2019, 11:08 AM
sidorovd committed rGd0d9779febf7: Remove unused const version of CommandInterpreter::GetCommandHistory. (authored by jingham).
Remove unused const version of CommandInterpreter::GetCommandHistory.
May 30 2019, 11:08 AM
sidorovd committed rG341175e5d1b0: [X86] Support -fno-plt __tls_get_addr calls (authored by MaskRay).
[X86] Support -fno-plt __tls_get_addr calls
May 30 2019, 11:08 AM
sidorovd committed rG515fd69dea04: [WebAssembly] Implement __builtin_return_address for emscripten (authored by tlively).
[WebAssembly] Implement __builtin_return_address for emscripten
May 30 2019, 11:08 AM
sidorovd committed rG42db9a1c2393: [libFuzzer] remove the data-flow-trace (DFT) python scripts; their… (authored by kcc).
[libFuzzer] remove the data-flow-trace (DFT) python scripts; their…
May 30 2019, 11:08 AM
sidorovd committed rG7a124bad0d1e: [ARM64][AArch64] Update disassembler attributes to ARMv8.5 ISA with SVE… (authored by omjavaid).
[ARM64][AArch64] Update disassembler attributes to ARMv8.5 ISA with SVE…
May 30 2019, 11:08 AM
sidorovd committed rG69c27398d320: [llvm-objcopy] Add file names to error messages (authored by seiya).
[llvm-objcopy] Add file names to error messages
May 30 2019, 11:08 AM
sidorovd committed rG6004228f47d9: gn build: Merge r361418. (authored by pcc).
gn build: Merge r361418.
May 30 2019, 11:08 AM
sidorovd committed rGdf93b8362d5d: [libFuzzer] automatically collect the data flow trace (DFT) in the fork mode if… (authored by kcc).
[libFuzzer] automatically collect the data flow trace (DFT) in the fork mode if…
May 30 2019, 11:07 AM
sidorovd committed rGfa2eca08dcf2: Ack, added DWARFTypeUnit to the wrong target... (authored by jingham).
Ack, added DWARFTypeUnit to the wrong target...
May 30 2019, 11:07 AM
sidorovd committed rG94aa1e382019: [FileCheck] Introduce substitution subclasses (authored by thopre).
[FileCheck] Introduce substitution subclasses
May 30 2019, 11:07 AM
sidorovd committed rGc01e4763f37a: FileCheck: Improve FileCheck variable terminology (authored by thopre).
FileCheck: Improve FileCheck variable terminology
May 30 2019, 11:07 AM
sidorovd committed rG4230f0b15957: [lldb] Fix use-of-uninitialized-value in Driver (authored by jgorbe).
[lldb] Fix use-of-uninitialized-value in Driver
May 30 2019, 11:07 AM
sidorovd committed rG9f87d9af00e9: Expression: correct relocation model for Windows (authored by compnerd).
Expression: correct relocation model for Windows
May 30 2019, 11:07 AM
sidorovd committed rG005684738fe3: [Target] Protect Processes' language runtimes map with a mutex (authored by xiaobai).
[Target] Protect Processes' language runtimes map with a mutex
May 30 2019, 11:07 AM
sidorovd committed rGe5cdc9a57753: [ORC] Remove a stray decl that accidentally found its way in to r361322. (authored by lhames).
[ORC] Remove a stray decl that accidentally found its way in to r361322.
May 30 2019, 11:07 AM
sidorovd committed rG24c2ec8c8a78: Actaully lock accesses to OptionValueFileSpecList objects (authored by friss).
Actaully lock accesses to OptionValueFileSpecList objects
May 30 2019, 11:07 AM
sidorovd committed rG67886c18cd6c: Fix r361428 for Windows buildbots/mangling (authored by dblaikie).
Fix r361428 for Windows buildbots/mangling
May 30 2019, 11:07 AM
sidorovd committed rG57b53af9053d: Fix new enum-codegen.cpp test (authored by rnk).
Fix new enum-codegen.cpp test
May 30 2019, 11:07 AM
sidorovd committed rGa3182002c075: [docs] Make a note of the HowToUseLLJIT example in the ORCv2 design doc. (authored by lhames).
[docs] Make a note of the HowToUseLLJIT example in the ORCv2 design doc.
May 30 2019, 11:07 AM
sidorovd committed rG3ac4f40ed601: [Runtimes] If LLVM_INCLUDE_TESTS=On depend on gtest (authored by beanz).
[Runtimes] If LLVM_INCLUDE_TESTS=On depend on gtest
May 30 2019, 11:07 AM
sidorovd committed rG6339314fd9c4: Add a HowToUseLLJIT example project. (authored by lhames).
Add a HowToUseLLJIT example project.
May 30 2019, 11:07 AM
sidorovd committed rG49790fc3e196: TableGen: Handle nontrivial foreach range bounds (authored by arsenm).
TableGen: Handle nontrivial foreach range bounds
May 30 2019, 11:06 AM
sidorovd committed rG52d0dbb24f37: Add some notes on immutability and faithfulness to the internals manual. (authored by Richard Smith <richard-llvm@metafoo.co.uk>).
Add some notes on immutability and faithfulness to the internals manual.
May 30 2019, 11:06 AM
sidorovd committed rG23b95ce250b5: [runtimes] Move libunwind, libc++abi and libc++ to lib/$target/c++ and… (authored by phosek).
[runtimes] Move libunwind, libc++abi and libc++ to lib/$target/c++ and…
May 30 2019, 11:06 AM
sidorovd committed rG34e727f337a5: [X86] Explcitly disable VEXTRACT instruction matching for an immediate of 0. (authored by craig.topper).
[X86] Explcitly disable VEXTRACT instruction matching for an immediate of 0.
May 30 2019, 11:06 AM
sidorovd committed rGa6531950f1fe: Reverted r361134 because of a failing test left unattended for a long time. (authored by gkistanova).
Reverted r361134 because of a failing test left unattended for a long time.
May 30 2019, 11:06 AM
sidorovd committed rGecf8b8732c7f: Modules: Code generation of enum constants for merged enum definitions (authored by dblaikie).
Modules: Code generation of enum constants for merged enum definitions
May 30 2019, 11:06 AM
sidorovd committed rGde1951d178fa: Add back --sysroot support for darwin header search. (authored by jyknight).
Add back --sysroot support for darwin header search.
May 30 2019, 11:06 AM
sidorovd committed rG695d85a81683: [asan] Fix debug asan build link error (authored by rnk).
[asan] Fix debug asan build link error
May 30 2019, 11:06 AM
sidorovd committed rGf09d813fbecf: Re-land r361206 "[COFF] Store alignment in log2 form, NFC" (authored by rnk).
Re-land r361206 "[COFF] Store alignment in log2 form, NFC"
May 30 2019, 11:05 AM
sidorovd committed rGb0c79d0149a0: [X86][InstCombine] Remove InstCombine code that turns X86 round intrinsics into… (authored by craig.topper).
[X86][InstCombine] Remove InstCombine code that turns X86 round intrinsics into…
May 30 2019, 11:05 AM
sidorovd committed rG7de97a88ce73: Part of P1091R3: permit structured bindings to be declared 'static' and… (authored by Richard Smith <richard-llvm@metafoo.co.uk>).
Part of P1091R3: permit structured bindings to be declared 'static' and…
May 30 2019, 11:05 AM
sidorovd committed rGa68ec217b62c: [X86] Add more icelake model numbers to compiler-rt implementation of… (authored by craig.topper).
[X86] Add more icelake model numbers to compiler-rt implementation of…
May 30 2019, 11:05 AM
sidorovd committed rGa9dbfdc5a423: [OPENMP][NVPTX]Fix barriers and parallel level counters, NFC. (authored by ABataev).
[OPENMP][NVPTX]Fix barriers and parallel level counters, NFC.
May 30 2019, 11:05 AM
sidorovd committed rGdfbebd04793c: [X86] Add more icelake model numbers to getHostCPUName. (authored by craig.topper).
[X86] Add more icelake model numbers to getHostCPUName.
May 30 2019, 11:05 AM
sidorovd committed rG831d56934fdb: Add DWARFTypeUnit to the Xcode project. (authored by jingham).
Add DWARFTypeUnit to the Xcode project.
May 30 2019, 11:04 AM
sidorovd committed rG2386333a74e1: [DebugInfo][AArch64] Recognise target specific instruction as mov instr (authored by avl).
[DebugInfo][AArch64] Recognise target specific instruction as mov instr
May 30 2019, 11:04 AM
sidorovd committed rG964e550f4ea3: gn build: Fix check-clangd target after r359825 (authored by thakis).
gn build: Fix check-clangd target after r359825
May 30 2019, 11:04 AM
sidorovd committed rGe1c225acdacd: [clang-tidy] Add support for writing a check as a Transformer rewrite rule. (authored by ymandel).
[clang-tidy] Add support for writing a check as a Transformer rewrite rule.
May 30 2019, 11:04 AM
sidorovd committed rG1827e09d14ed: [PGO][CHR] Speed up following long use-def chains. (authored by yamauchi).
[PGO][CHR] Speed up following long use-def chains.
May 30 2019, 11:04 AM
sidorovd committed rGa2a4daa0e510: [libcxx][test] Fix order checking in some more unordered_multimap tests (authored by ldionne).
[libcxx][test] Fix order checking in some more unordered_multimap tests
May 30 2019, 11:04 AM
sidorovd committed rG9da7303102fc: [NFC][InstCombine] Add unary fneg tests to maxnum.ll/minnum.ll (authored by cameron.mcinally).
[NFC][InstCombine] Add unary fneg tests to maxnum.ll/minnum.ll
May 30 2019, 11:04 AM
sidorovd committed rG0454b95df663: [LibTooling] Update Stencil to use RangeSelector (authored by ymandel).
[LibTooling] Update Stencil to use RangeSelector
May 30 2019, 11:04 AM
sidorovd committed rG5f27f3cf7406: [EditLine] Rewrite GetHistoryFilePath (authored by JDevlieghere).
[EditLine] Rewrite GetHistoryFilePath
May 30 2019, 11:04 AM
sidorovd committed rG25fa2e6b9d78: Fixed a -Wunused-variable warning when assertions are disabled (authored by gribozavr).
Fixed a -Wunused-variable warning when assertions are disabled
May 30 2019, 11:04 AM
sidorovd committed rGdf7af04a203a: Disable EHFrameSupport in JITLink/RuntimeDyld on AIX (authored by xingxue).
Disable EHFrameSupport in JITLink/RuntimeDyld on AIX
May 30 2019, 11:04 AM
sidorovd committed rGe11a570dcfd3: [NFC][X86][AArch64] Add tests for missing (x - y) + -1 -> not(y) + x fold (authored by lebedev.ri).
[NFC][X86][AArch64] Add tests for missing (x - y) + -1 -> not(y) + x fold
May 30 2019, 11:04 AM
sidorovd committed rG54264cce74d4: Fixed third issue reported in https://bugs.llvm.org/show_bug.cgi?id=41584. (authored by AndreyChurbanov).
Fixed third issue reported in https://bugs.llvm.org/show_bug.cgi?id=41584.
May 30 2019, 11:04 AM
sidorovd committed rGa88dd3e96732: [libFuzzer] Ignore synthetic exceptions on Fuchsia (authored by phosek).
[libFuzzer] Ignore synthetic exceptions on Fuchsia
May 30 2019, 11:04 AM
sidorovd committed rG1acee7b2bceb: MC: Allow getMaxInstLength to depend on the subtarget (authored by arsenm).
MC: Allow getMaxInstLength to depend on the subtarget
May 30 2019, 11:04 AM
sidorovd committed rGf3935830c2ed: AMDGPU: Move disassembler support check to constructor (authored by arsenm).
AMDGPU: Move disassembler support check to constructor
May 30 2019, 11:04 AM
sidorovd committed rG99c5eb2f357e: [TargetLowering] Extend bool args to inline-asm according to getBooleanType (authored by kees).
[TargetLowering] Extend bool args to inline-asm according to getBooleanType
May 30 2019, 11:04 AM
sidorovd committed rG4fc3bc06c132: [TargetLowering] Add blank line (test commit) (authored by kees).
[TargetLowering] Add blank line (test commit)
May 30 2019, 11:03 AM
sidorovd committed rGd7e902281da2: llvm-undname: Fix an assert-on-invalid, found by oss-fuzz (authored by thakis).
llvm-undname: Fix an assert-on-invalid, found by oss-fuzz
May 30 2019, 11:03 AM
sidorovd committed rGbf4eae5bb6e7: Combine two if cases because the second one is never reached. (authored by akhuang).
Combine two if cases because the second one is never reached.
May 30 2019, 11:03 AM
sidorovd committed rGe09145d2518d: [IR] allow fast-math-flags on select of FP values (authored by spatel).
[IR] allow fast-math-flags on select of FP values
May 30 2019, 11:03 AM
sidorovd committed rG6c72ddb81f65: Unbreak non-PIC builds after r361340/D62174 (authored by davezarzycki).
Unbreak non-PIC builds after r361340/D62174
May 30 2019, 11:03 AM
sidorovd committed rG1ab18aede4d7: [NFC][ARM] Autogenerate addsubcarry-promotion.ll test (authored by lebedev.ri).
[NFC][ARM] Autogenerate addsubcarry-promotion.ll test
May 30 2019, 11:03 AM
sidorovd committed rGe600d299390d: [NFC][X86] Autogenerate negative-offset.ll test (authored by lebedev.ri).
[NFC][X86] Autogenerate negative-offset.ll test
May 30 2019, 11:03 AM