This is an archive of the discontinued LLVM Phabricator instance.

[analyzer][UninitializedObjectChecker] Updated comments
ClosedPublic

Authored by Szelethus on Aug 29 2018, 5:56 AM.

Details

Summary

Some of the comments are incorrect, imprecise, or simply nonexistent. Since I have a better grasp on how the analyzer works, it makes sense to update most of them in a single swoop.

I tried not to flood the code with comments too much, this amount feels just right to me.

Diff Detail

Event Timeline

Szelethus created this revision.Aug 29 2018, 5:56 AM
Szelethus added inline comments.
lib/StaticAnalyzer/Checkers/UninitializedObject/UninitializedObjectChecker.cpp
377–397

Fixed in rC339653, but apparently I forgot to remove this.

Polite ping ^-^

NoQ accepted this revision.Sep 6 2018, 6:39 PM

Comments always welcome!

lib/StaticAnalyzer/Checkers/UninitializedObject/UninitializedObjectChecker.cpp
363–364

Ugh, why is it not const?

This revision is now accepted and ready to land.Sep 6 2018, 6:39 PM
This revision was automatically updated to reflect the committed changes.