This is an archive of the discontinued LLVM Phabricator instance.

llvm: Fix MIPS N32 triples support
ClosedPublic

Authored by wzssyqa on Aug 29 2018, 2:13 AM.

Details

Summary

Add support mips64(el)-linux-gnuabin32 triples, and set them to N32.
Debian architecture name mipsn32/mipsn32el are also added.

Set UseIntegratedAssembler for N32 if we can detect it.

Diff Detail

Repository
rL LLVM

Event Timeline

wzssyqa created this revision.Aug 29 2018, 2:13 AM
atanasyan added inline comments.Aug 29 2018, 2:29 AM
lib/Target/Mips/MCTargetDesc/MipsAsmBackend.cpp
575

In general, this change is good. But it highlights a problem - there is two entities hold ABI info. The first one is Option.ABIName, the second one is getEnvironment. Both options should be consistent. Is it possible to set ABIName to n32 always if getEnvironment is GNUABIN32 and check just ABIName here?

wzssyqa updated this revision to Diff 163058.Aug 29 2018, 5:31 AM
wzssyqa retitled this revision from Fix MIPS N32 triples support to llvm: Fix MIPS N32 triples support.Aug 29 2018, 9:36 AM
This revision is now accepted and ready to land.Sep 1 2018, 12:05 AM
This revision was automatically updated to reflect the committed changes.

Thanks for the patch.