This check warns the uses of the deprecated member types of std::ios_base
and replaces those that have a non-deprecated equivalent.
Details
- Reviewers
alexfh aaron.ballman hokein ilya-biryukov
Diff Detail
Event Timeline
Hi andobence,
thank you for the contribution. The check looks very good!
Please add it to the release notes and synchronize the first line of the doc with the short sentence in the release notes describing what this check does.
clang-tidy/modernize/DeprecatedIosBaseAliasesCheck.h | ||
---|---|---|
20 | I I think you can write non-deprecated without the whitespace. | |
test/clang-tidy/modernize-deprecated-ios-base-aliases.cpp | ||
14 | That format looks weird. Could you please run clang-format over the test as well? |
clang-tidy/modernize/DeprecatedIosBaseAliasesCheck.cpp | ||
---|---|---|
34 | Which standard supplies the replacement functionality? e.g. for C++98 the warning is probably not relevant because there is no way to replace the deprecated types, but for C++17 it is possible. |
clang-tidy/modernize/DeprecatedIosBaseAliasesCheck.cpp | ||
---|---|---|
34 | C++98 already has them, these types has been deprecated since draft N0785 from 1995. |
LG from my side, please rebase that patch on top of master. Currently the Release Notes would conflict (and please sort the release note alphabetically).
If the other reviewers do not say anything within a reasonable time it can be committed. Do you have commit rights?
And i forgot: Could you please run this over a real code base, if you know one that actually uses these types?
I assume not so many code bases actually use these.
I I think you can write non-deprecated without the whitespace.