Page MenuHomePhabricator

[debuginfo] generate debug info with asm+.file
ClosedPublic

Authored by bcain on Aug 27 2018, 11:20 AM.

Details

Diff Detail

Repository
rL LLVM

Event Timeline

bcain created this revision.Aug 27 2018, 11:20 AM

Comments:

llvm/lib/MC/MCParser/AsmParser.cpp
3354–3361 ↗(On Diff #162717)

This code block is the interesting part moreso than the if/else.

Before r328208, an effect similar to this was in the else clause (FileNumber != 1).

probinson accepted this revision.Aug 27 2018, 12:53 PM

The indentation in the test looks a little odd. Please verify there are no hard tabs.
Otherwise LGTM.

Please cite the PR number in the commit message, when you push this.

This revision is now accepted and ready to land.Aug 27 2018, 12:53 PM
bcain updated this revision to Diff 162738.Aug 27 2018, 1:33 PM
  • Changed indentation for nop
  • Added PR number to summary
bcain added a comment.Aug 27 2018, 1:34 PM

The indentation in the test looks a little odd. Please verify there are no hard tabs.
Otherwise LGTM.

Please cite the PR number in the commit message, when you push this.

There's no hard tabs. The only indentation oddness that I identified was the 4-space indentation for nop versus 8-space for the .file directive. Corrected nop to match the .file.

Awesome thanks!

This revision was automatically updated to reflect the committed changes.