Page MenuHomePhabricator

[DEBUGINFO] Add support for emission of the debug directives only.
ClosedPublic

Authored by ABataev on Aug 23 2018, 11:20 AM.

Details

Summary

Added option -glineinfo-only to support emission of the debug directives
only. It behaves very similar to -gline-tables-only, except that it sets
llvm debug info emission kind to
llvm::DICompileUnit::DebugDirectivesOnly.

Diff Detail

Repository
rL LLVM

Event Timeline

ABataev created this revision.Aug 23 2018, 11:20 AM

Should we just have them mean the same thing and change it based on target?

Should we just have them mean the same thing and change it based on target?

I reused the same debug info level support in clang, but in LLVM they have different processing and I'm not sure that they are absolutely compatible.

dblaikie added inline comments.
test/Driver/debug-options.c
259 ↗(On Diff #162237)

'lineinfo' seems like two words - the inconsistency with 'line-tables' seems like it'd be confusing.

But also I'm not sure line-table versus line-info is very differentiating. Maybe line-directives-only?

ABataev updated this revision to Diff 163353.Aug 30 2018, 9:29 AM

Address comment from David.

dblaikie accepted this revision.Aug 30 2018, 1:40 PM

Not sure that every test for line-tables-only needs to also test line-directives-only, but not a huge deal either way. (only the cases where there's actually a different codepath to test/new code to validate would I bother testing - rather than duplicating all the tests)

Looks good.

This revision is now accepted and ready to land.Aug 30 2018, 1:40 PM
This revision was automatically updated to reflect the committed changes.