This is an archive of the discontinued LLVM Phabricator instance.

[gold] -thinlto-object-suffix-replace: don't append new suffix if path does not end with old suffix
ClosedPublic

Authored by MaskRay on Aug 21 2018, 1:02 PM.

Diff Detail

Repository
rL LLVM

Event Timeline

MaskRay created this revision.Aug 21 2018, 1:02 PM

Let's hold on this review until we resolve the discussion on the lld patch first. I'd like to understand more about why we are hitting this case.

Based on decision in D51055 we should go forward with this change to be consistent with lld. But please add a test and summary.

MaskRay updated this revision to Diff 161869.Aug 21 2018, 6:00 PM
MaskRay edited the summary of this revision. (Show Details)
MaskRay removed subscribers: mehdi_amini, eraman, steven_wu.

Update summary with arc diff --edit --verbatim

tejohnson accepted this revision.Aug 21 2018, 6:40 PM

LGTM. Thanks for the cleanup!

This revision is now accepted and ready to land.Aug 21 2018, 6:40 PM
This revision was automatically updated to reflect the committed changes.