This is an archive of the discontinued LLVM Phabricator instance.

Differential D50816

[hexagon] restore -fuse-cxa-atexit by default
ClosedPublic

Authored by bcain on Aug 15 2018, 3:25 PM.

Details

Reviewers
bcahoon
sidneym
kparzysz
Commits
rGd6a76f761f57: [hexagon] restore -fuse-cxa-atexit by default
rC339979: [hexagon] restore -fuse-cxa-atexit by default
rL339979: [hexagon] restore -fuse-cxa-atexit by default
Summary

"-fno-use-cxa-atexit" was a default provided by the initial
commit offering hexagon support. This is no longer required.

Diff Detail

Repository
rC Clang

Event Timeline

bcain created this revision.Aug 15 2018, 3:25 PM
Herald added a subscriber: llvm-commits. · View Herald TranscriptAug 15 2018, 3:25 PM
Harbormaster completed remote builds in B21543: Diff 160928.Aug 15 2018, 3:25 PM
bcain added a reviewer: kparzysz.Aug 16 2018, 8:42 AM
kparzysz accepted this revision.Aug 16 2018, 11:00 AM
This revision is now accepted and ready to land.Aug 16 2018, 11:00 AM
Closed by commit rL339979: [hexagon] restore -fuse-cxa-atexit by default (authored by bcain). · Explain WhyAug 16 2018, 8:54 PM
Closed by commit rC339979: [hexagon] restore -fuse-cxa-atexit by default (authored by bcain). · Explain Why
This revision was automatically updated to reflect the committed changes.
This revision was automatically updated to reflect the committed changes.
Herald added a subscriber: cfe-commits. · View Herald TranscriptAug 16 2018, 8:54 PM

Revision Contents

PathSize
lib/
Driver/
ToolChains/
1 line
test/
Driver/
2 lines

Diff 161160

lib/Driver/ToolChains/Clang.cpp

Show First 20 Lines • Show All 4,219 Lines • ▼ Show 20 Lines#endif
RenderCharacterOptions(Args, AuxTriple ? *AuxTriple : RawTriple, CmdArgs); RenderCharacterOptions(Args, AuxTriple ? *AuxTriple : RawTriple, CmdArgs);
// -fuse-cxa-atexit is default. // -fuse-cxa-atexit is default.
if (!Args.hasFlag( if (!Args.hasFlag(
options::OPT_fuse_cxa_atexit, options::OPT_fno_use_cxa_atexit, options::OPT_fuse_cxa_atexit, options::OPT_fno_use_cxa_atexit,
!RawTriple.isOSWindows() && !RawTriple.isOSWindows() &&
RawTriple.getOS() != llvm::Triple::Solaris && RawTriple.getOS() != llvm::Triple::Solaris &&
getToolChain().getArch() != llvm::Triple::hexagon &&
getToolChain().getArch() != llvm::Triple::xcore && getToolChain().getArch() != llvm::Triple::xcore &&
((RawTriple.getVendor() != llvm::Triple::MipsTechnologies) || ((RawTriple.getVendor() != llvm::Triple::MipsTechnologies) ||
RawTriple.hasEnvironment())) || RawTriple.hasEnvironment())) ||
KernelOrKext) KernelOrKext)
CmdArgs.push_back("-fno-use-cxa-atexit"); CmdArgs.push_back("-fno-use-cxa-atexit");
if (Args.hasFlag(options::OPT_fregister_global_dtors_with_atexit, if (Args.hasFlag(options::OPT_fregister_global_dtors_with_atexit,
options::OPT_fno_register_global_dtors_with_atexit, options::OPT_fno_register_global_dtors_with_atexit,
▲ Show 20 Lines • Show All 1,478 Lines • Show Last 20 Lines

test/Driver/cxa-atexit.cpp

Show All 14 Lines
// RUN: %clang -### -target armv7-mti-none -c %s -o /dev/null 2>&1 | FileCheck %s -check-prefix CHECK-MTI // RUN: %clang -### -target armv7-mti-none -c %s -o /dev/null 2>&1 | FileCheck %s -check-prefix CHECK-MTI
// RUN: %clang -### -target mips-unknown-none -c %s -o /dev/null 2>&1 | FileCheck %s -check-prefix CHECK-MIPS // RUN: %clang -### -target mips-unknown-none -c %s -o /dev/null 2>&1 | FileCheck %s -check-prefix CHECK-MIPS
// RUN: %clang -### -target mips-unknown-none-gnu -c %s -o /dev/null 2>&1 | FileCheck %s -check-prefix CHECK-MIPS // RUN: %clang -### -target mips-unknown-none-gnu -c %s -o /dev/null 2>&1 | FileCheck %s -check-prefix CHECK-MIPS
// RUN: %clang -### -target mips-mti-none-gnu -c %s -o /dev/null 2>&1 | FileCheck %s -check-prefix CHECK-MIPS // RUN: %clang -### -target mips-mti-none-gnu -c %s -o /dev/null 2>&1 | FileCheck %s -check-prefix CHECK-MIPS
// RUN: %clang -### -target sparc-sun-solaris -c %s -o /dev/null 2>&1 | FileCheck %s -check-prefix CHECK-SOLARIS // RUN: %clang -### -target sparc-sun-solaris -c %s -o /dev/null 2>&1 | FileCheck %s -check-prefix CHECK-SOLARIS
// CHECK-WINDOWS: "-fno-use-cxa-atexit" // CHECK-WINDOWS: "-fno-use-cxa-atexit"
// CHECK-SOLARIS: "-fno-use-cxa-atexit" // CHECK-SOLARIS: "-fno-use-cxa-atexit"
// CHECK-HEXAGON: "-fno-use-cxa-atexit" // CHECK-HEXAGON-NOT: "-fno-use-cxa-atexit"
// CHECK-XCORE: "-fno-use-cxa-atexit" // CHECK-XCORE: "-fno-use-cxa-atexit"
// CHECK-MTI: "-fno-use-cxa-atexit" // CHECK-MTI: "-fno-use-cxa-atexit"
// CHECK-MIPS-NOT: "-fno-use-cxa-atexit" // CHECK-MIPS-NOT: "-fno-use-cxa-atexit"
// RUN: %clang -target x86_64-apple-darwin -fregister-global-dtors-with-atexit -fno-register-global-dtors-with-atexit -c -### %s 2>&1 | \ // RUN: %clang -target x86_64-apple-darwin -fregister-global-dtors-with-atexit -fno-register-global-dtors-with-atexit -c -### %s 2>&1 | \
// RUN: FileCheck --check-prefix=WITHOUTATEXIT %s // RUN: FileCheck --check-prefix=WITHOUTATEXIT %s
// RUN: %clang -target x86_64-apple-darwin -fno-register-global-dtors-with-atexit -fregister-global-dtors-with-atexit -c -### %s 2>&1 | \ // RUN: %clang -target x86_64-apple-darwin -fno-register-global-dtors-with-atexit -fregister-global-dtors-with-atexit -c -### %s 2>&1 | \
// RUN: FileCheck --check-prefix=WITHATEXIT %s // RUN: FileCheck --check-prefix=WITHATEXIT %s
Show All 13 Lines