Page MenuHomePhabricator

SafeStack: Disable Darwin support
ClosedPublic

Authored by vlad.tsyrklevich on Aug 14 2018, 9:27 AM.

Details

Summary

Darwin support does not appear to be used as evidenced by the fact that
the pthread interceptors have never worked and there is no support for
other common threading mechanisms like GCD.

Diff Detail

Event Timeline

pcc accepted this revision.Aug 14 2018, 10:13 AM
pcc added a subscriber: kubamracek.

LGTM

(@kubamracek FYI)

This revision is now accepted and ready to land.Aug 14 2018, 10:13 AM

Yes, this looks good, SafeStack has never worked on non-trivial programs on Darwin. Does the Clang driver also need a patch?

Yes, this looks good, SafeStack has never worked on non-trivial programs on Darwin. Does the Clang driver also need a patch?

It does! Thanks for reminding me, that change is https://reviews.llvm.org/D50724

kubamracek accepted this revision.Aug 14 2018, 10:23 AM

Cool, LGTM.

This revision was automatically updated to reflect the committed changes.