This is an archive of the discontinued LLVM Phabricator instance.

[clangd] NFC: Mark Workspace Symbol feature complete in the documentation
ClosedPublic

Authored by kbobyrev on Aug 14 2018, 6:33 AM.

Diff Detail

Repository
rL LLVM

Event Timeline

kbobyrev created this revision.Aug 14 2018, 6:33 AM
ioeric accepted this revision.Aug 16 2018, 6:50 AM
This revision is now accepted and ready to land.Aug 16 2018, 6:50 AM
This revision was automatically updated to reflect the committed changes.
This revision was automatically updated to reflect the committed changes.

I hadn't marked it as done because without symbols in main files I found it quite lacking.

I hadn't marked it as done because without symbols in main files I found it quite lacking.

Ah, I see, thank you for spotting it! I was under the impression that it's feature-complete. Should I mark it "Partial" until this is fixed then?

I hadn't marked it as done because without symbols in main files I found it quite lacking.

Ah, I see, thank you for spotting it! I was under the impression that it's feature-complete. Should I mark it "Partial" until this is fixed then?

Nah, I guess other things are partial too, like Go to Definition. Let's assume they will be completed "soon" ;)

Nah, I guess other things are partial too, like Go to Definition. Let's assume they will be completed "soon" ;)

D50889 should finally add the symbols from the main files. Sorry for the delays.