This is an archive of the discontinued LLVM Phabricator instance.

Differential D50657

Add R_HEX_32 relocation support
ClosedPublic

Authored by sidneym on Aug 13 2018, 11:54 AM.

Details

Reviewers
ruiu
bcain
kparzysz
shankare
• espindola
Commits
rG5b0141c49e50: [ELF][HEXAGON] Add R_HEX_32 support
rLLD339677: [ELF][HEXAGON] Add R_HEX_32 support
rL339677: [ELF][HEXAGON] Add R_HEX_32 support
Summary

Add support for R_HEX_32 relocation.

Diff Detail

Repository
rL LLVM

Event Timeline

sidneym created this revision.Aug 13 2018, 11:54 AM
Herald added a reviewer: • espindola. · View Herald TranscriptAug 13 2018, 11:54 AM
Herald added subscribers: arichardson, emaste. · View Herald Transcript
bcain accepted this revision.Aug 13 2018, 12:37 PM

LGTM

This revision is now accepted and ready to land.Aug 13 2018, 12:37 PM
Closed by commit rL339677: [ELF][HEXAGON] Add R_HEX_32 support (authored by sidneym). · Explain WhyAug 14 2018, 6:53 AM
This revision was automatically updated to reflect the committed changes.
ruiu added inline comments.Aug 19 2018, 11:20 PM
lld/trunk/ELF/Arch/Hexagon.cpp
132

applyMask(0xffffffff, ...) seems to be a no-op. Can you just use Val?

sidneym added inline comments.Aug 20 2018, 6:13 AM
lld/trunk/ELF/Arch/Hexagon.cpp
132

Sure, I'll update yet to be committed https://reviews.llvm.org/D50603 with this change

Revision Contents

PathSize
lld/
trunk/
ELF/
Arch/
3 lines
test/
ELF/
5 lines

Diff 160573

lld/trunk/ELF/Arch/Hexagon.cpp

Show First 20 Lines • Show All 122 Lines • ▼ Show 20 Lines case R_HEX_6_X:
or32le(Loc, applyMask(findMaskR6(read32le(Loc)), Val)); or32le(Loc, applyMask(findMaskR6(read32le(Loc)), Val));
break; break;
case R_HEX_8_X: case R_HEX_8_X:
or32le(Loc, applyMask(findMaskR8(read32le(Loc)), Val)); or32le(Loc, applyMask(findMaskR8(read32le(Loc)), Val));
break; break;
case R_HEX_12_X: case R_HEX_12_X:
or32le(Loc, applyMask(0x000007e0, Val)); or32le(Loc, applyMask(0x000007e0, Val));
break; break;
case R_HEX_32:
or32le(Loc, applyMask(0xffffffff, Val));
ruiuUnsubmitted
Not Done
ReplyInline Actions

applyMask(0xffffffff, ...) seems to be a no-op. Can you just use Val?

ruiu: `applyMask(0xffffffff, ...)` seems to be a no-op. Can you just use `Val`?
sidneymAuthorUnsubmitted
Not Done
ReplyInline Actions

Sure, I'll update yet to be committed https://reviews.llvm.org/D50603 with this change

sidneym: Sure, I'll update yet to be committed https://reviews.llvm.org/D50603 with this change
break;
case R_HEX_32_6_X: case R_HEX_32_6_X:
or32le(Loc, applyMask(0x0fff3fff, Val >> 6)); or32le(Loc, applyMask(0x0fff3fff, Val >> 6));
break; break;
case R_HEX_B15_PCREL: case R_HEX_B15_PCREL:
or32le(Loc, applyMask(0x00df20fe, Val >> 2)); or32le(Loc, applyMask(0x00df20fe, Val >> 2));
break; break;
case R_HEX_B15_PCREL_X: case R_HEX_B15_PCREL_X:
or32le(Loc, applyMask(0x00df20fe, Val & 0x3f)); or32le(Loc, applyMask(0x00df20fe, Val & 0x3f));
Show All 26 Lines

lld/trunk/test/ELF/hexagon.s

Show First 20 Lines • Show All 166 Lines • ▼ Show 20 Lines
#0x3c000000 #0x3c000000
memw(r0+#0) = ##_start memw(r0+#0) = ##_start
# CHECK: 3c40c000 memw(r0+#0) = ##69632 } # CHECK: 3c40c000 memw(r0+#0) = ##69632 }
# The rest: # The rest:
r1:0=combine(r2,##_start); r1:0=combine(r2,##_start);
# CHECK: 7302e000 r1:0 = combine(r2,##69632) } # CHECK: 7302e000 r1:0 = combine(r2,##69632) }
# R_HEX_32:
r_hex_32:
.word _start
# CHECK: 00011000