This is an archive of the discontinued LLVM Phabricator instance.

[clang] Store code completion token range in preprocessor.
ClosedPublic

Authored by kadircet on Aug 8 2018, 6:06 AM.

Diff Detail

Event Timeline

kadircet created this revision.Aug 8 2018, 6:06 AM

Maybe split the commit message into multiple lines?

I suggest we wait for clangd changes to be reviewed and land them together, so that we have the tests and usages of this code.
Other than that LG

include/clang/Lex/Preprocessor.h
1139

NIT: parameters are are UpperCamelCase in LLVM naming conventions

kadircet retitled this revision from [clang] Store code completion token range in preprocessor. This change is to support a new fature in clangd, tests will be send to clang-tools-extra with that change. to [clang] Store code completion token range in preprocessor..Aug 8 2018, 6:20 AM
kadircet edited the summary of this revision. (Show Details)
kadircet updated this revision to Diff 159703.Aug 8 2018, 6:21 AM
kadircet marked an inline comment as done.
  • Resolve discussions.
ilya-biryukov accepted this revision.Aug 10 2018, 7:14 AM

LGTM, but let's land together with a dependent revision to hove some code that actually tests it.

include/clang/Lex/Preprocessor.h
313

NIT: s/taken/token

This revision is now accepted and ready to land.Aug 10 2018, 7:14 AM

NIT: maybe also note the number of the clangd revision in this change's description

kadircet updated this revision to Diff 160299.Aug 13 2018, 1:09 AM
  • Resolve discussions.
  • Fix typo.
kadircet edited the summary of this revision. (Show Details)Aug 13 2018, 1:10 AM
kadircet marked an inline comment as done.
This revision was automatically updated to reflect the committed changes.