This is an archive of the discontinued LLVM Phabricator instance.

Differential D50440

[LLD] Add missing REQUIRES x86 to tests.
ClosedPublic

Authored by peter.smith on Aug 8 2018, 5:45 AM.

Details

Reviewers
ruiu
grimar
• espindola
Commits
rG3d3c7c2e04f9: Merging r339253: --------------------------------------------------------------…
rG5c579572811f: Add missing REQUIRES x86 to tests.
rL341367: Merging r339253:
rLLD339253: Add missing REQUIRES x86 to tests.
rL339253: Add missing REQUIRES x86 to tests.
Summary

Add REQUIRES to tests that fail when an x86 backend is not present.

There was a recent review D47748 to add REQUIRES x86 to all the tests that needed X86. Since that landed there have been a few new tests added without REQUIRES. We are going to remove the X86 backend from one of the linaro buildbots to speed it up and can keep the LLD tests up to date. The tests were identified by a run of the buildbot.

FAIL: lld::guardcf-align.s
FAIL: lld::icf16.s
FAIL: lld::icf13.s
FAIL: lld::icf15.s
FAIL: lld::icf17.s
FAIL: lld::libcall-archive.ll

Diff Detail

Repository
rL LLVM

Event Timeline

peter.smith created this revision.Aug 8 2018, 5:45 AM
Herald added a reviewer: • espindola. · View Herald TranscriptAug 8 2018, 5:45 AM
Herald added subscribers: dexonsmith, steven_wu, arichardson, emaste. · View Herald Transcript
grimar accepted this revision.Aug 8 2018, 6:33 AM

LGTM.

This revision is now accepted and ready to land.Aug 8 2018, 6:33 AM
Closed by commit rL339253: Add missing REQUIRES x86 to tests. (authored by psmith). · Explain WhyAug 8 2018, 7:51 AM
This revision was automatically updated to reflect the committed changes.
ruiu added a comment.Aug 8 2018, 11:14 AM

LGTM

Revision Contents

PathSize
lld/
trunk/
test/
COFF/
1 line
ELF/
1 line
1 line
1 line
1 line
lto/
1 line

Diff 159721

lld/trunk/test/COFF/guardcf-align.s

# REQUIRES: x86
# RUN: llvm-mc -triple x86_64-windows-msvc -filetype=obj -o %t.obj %s # RUN: llvm-mc -triple x86_64-windows-msvc -filetype=obj -o %t.obj %s
# RUN: yaml2obj < %p/Inputs/guardcf-align-foobar.yaml \ # RUN: yaml2obj < %p/Inputs/guardcf-align-foobar.yaml \
# RUN: > %T/guardcf-align-foobar.obj # RUN: > %T/guardcf-align-foobar.obj
# RUN: lld-link -out:%T/guardcf-align.exe -entry:main -guard:cf \ # RUN: lld-link -out:%T/guardcf-align.exe -entry:main -guard:cf \
# RUN: %t.obj %T/guardcf-align-foobar.obj # RUN: %t.obj %T/guardcf-align-foobar.obj
# RUN: llvm-readobj -coff-load-config %T/guardcf-align.exe | FileCheck %s # RUN: llvm-readobj -coff-load-config %T/guardcf-align.exe | FileCheck %s
# Check that the gfids table contains at least one entry that ends in 0 # Check that the gfids table contains at least one entry that ends in 0
Show All 37 Lines

lld/trunk/test/ELF/icf13.s

# REQUIRES: x86
# RUN: llvm-mc -filetype=obj -triple=x86_64-unknown-linux %s -o %t1 # RUN: llvm-mc -filetype=obj -triple=x86_64-unknown-linux %s -o %t1
# RUN: ld.lld -shared -z notext %t1 -o /dev/null --icf=all --print-icf-sections 2>&1 | FileCheck -allow-empty %s # RUN: ld.lld -shared -z notext %t1 -o /dev/null --icf=all --print-icf-sections 2>&1 | FileCheck -allow-empty %s
## Check that ICF does not merge sections which relocations point to symbols ## Check that ICF does not merge sections which relocations point to symbols
## that are not of the regular defined kind. ## that are not of the regular defined kind.
# CHECK-NOT: selected # CHECK-NOT: selected
Show All 12 Lines

lld/trunk/test/ELF/icf15.s

# REQUIRES: x86
# RUN: llvm-mc -filetype=obj -triple=x86_64-unknown-linux %s -o %t1 # RUN: llvm-mc -filetype=obj -triple=x86_64-unknown-linux %s -o %t1
# RUN: ld.lld %t1 -o /dev/null --icf=all --print-icf-sections 2>&1 | FileCheck -allow-empty %s # RUN: ld.lld %t1 -o /dev/null --icf=all --print-icf-sections 2>&1 | FileCheck -allow-empty %s
## Check that ICF does not merge sections which relocations have equal addends, ## Check that ICF does not merge sections which relocations have equal addends,
## but different target values. ## but different target values.
# CHECK-NOT: selected # CHECK-NOT: selected
Show All 15 Lines

lld/trunk/test/ELF/icf16.s

# REQUIRES: x86
# RUN: llvm-mc -filetype=obj -triple=x86_64-unknown-linux %s -o %t1 # RUN: llvm-mc -filetype=obj -triple=x86_64-unknown-linux %s -o %t1
# RUN: ld.lld -shared -z notext %t1 -o /dev/null --icf=all --print-icf-sections 2>&1 | FileCheck -allow-empty %s # RUN: ld.lld -shared -z notext %t1 -o /dev/null --icf=all --print-icf-sections 2>&1 | FileCheck -allow-empty %s
## ICF is able to merge sections which relocations referring regular input sections ## ICF is able to merge sections which relocations referring regular input sections
## or mergeable sections. .eh_frame is represented with a different kind of section, ## or mergeable sections. .eh_frame is represented with a different kind of section,
## here we check that ICF code is able to handle and will not merge sections which ## here we check that ICF code is able to handle and will not merge sections which
## relocations referring .eh_frame. ## relocations referring .eh_frame.
Show All 15 Lines

lld/trunk/test/ELF/icf17.s

# REQUIRES: x86
# RUN: llvm-mc -filetype=obj -triple=x86_64-unknown-linux %s -o %t1 # RUN: llvm-mc -filetype=obj -triple=x86_64-unknown-linux %s -o %t1
# RUN: ld.lld %t1 -o /dev/null --icf=all --print-icf-sections 2>&1 | FileCheck -allow-empty %s # RUN: ld.lld %t1 -o /dev/null --icf=all --print-icf-sections 2>&1 | FileCheck -allow-empty %s
# CHECK-NOT: selected # CHECK-NOT: selected
.section .text .section .text
.globl _start .globl _start
_start: _start:
ret ret
.section .aaa, "ax",%progbits,unique,1 .section .aaa, "ax",%progbits,unique,1
.quad _start .quad _start
.section .aaa, "axS",%progbits,unique,2 .section .aaa, "axS",%progbits,unique,2
.quad _start .quad _start

lld/trunk/test/ELF/lto/libcall-archive.ll

; REQUIRES: x86
; RUN: rm -f %t.a ; RUN: rm -f %t.a
; RUN: llvm-as -o %t.o %s ; RUN: llvm-as -o %t.o %s
; RUN: llvm-as -o %t2.o %S/Inputs/libcall-archive.ll ; RUN: llvm-as -o %t2.o %S/Inputs/libcall-archive.ll
; RUN: llvm-ar rcs %t.a %t2.o ; RUN: llvm-ar rcs %t.a %t2.o
; RUN: ld.lld -o %t %t.o %t.a ; RUN: ld.lld -o %t %t.o %t.a
; RUN: llvm-nm %t | FileCheck %s ; RUN: llvm-nm %t | FileCheck %s
; CHECK: T _start ; CHECK: T _start
Show All 12 Lines