Page MenuHomePhabricator

[lld] Add REQUIRES: x86 where needed to tests
ClosedPublic

Authored by joel_k_jones on Jun 4 2018, 4:28 PM.

Details

Summary

If building lld without x86 support, tests that require that support should be treated as unsupported, not errors.

Patch by Joel Jones

Diff Detail

Repository
rL LLVM

Event Timeline

joel_k_jones created this revision.Jun 4 2018, 4:28 PM
peter.smith added a subscriber: peter.smith.

This looks good to me. I've checked that each of the files has some requirement such as an x86 target triple. I've added the code owner Rui and a frequent contributor George to see if they have any objections.

ruiu accepted this revision.Jun 5 2018, 7:59 AM

LGTM

test/COFF/export-all.s
1 ↗(On Diff #149870)

Ouch

This revision is now accepted and ready to land.Jun 5 2018, 7:59 AM
This revision was automatically updated to reflect the committed changes.