The line
cmake_minimum_required(VERSION 3.4.3)
already has the effect of setting to NEW all policies present in that
release:
https://cmake.org/cmake/help/v3.4/manual/cmake-policies.7.html
Differential D50407
Remove obsolete policy settings steveire on Aug 7 2018, 2:38 PM. Authored by
Details The line cmake_minimum_required(VERSION 3.4.3) already has the effect of setting to NEW all policies present in that https://cmake.org/cmake/help/v3.4/manual/cmake-policies.7.html
Diff Detail
Event TimelineComment Actions looks good, thanks! (do you have commit rights - or would you like me to commit this for you?)
|
This removal was incorrect. https://cmake.org/cmake/help/v3.4/policy/CMP0056.html says "Unlike most policies, CMake version 3.4.3 does not warn by default when this policy is not set and simply uses OLD behavior (and even the latest version's documentaion says the same).
In general, @beanz, @phosek, @mgorny and I make good reviewers for CMake changes.