This is an archive of the discontinued LLVM Phabricator instance.

Refactor FileCheck to be used as API
ClosedPublic

Authored by aditya_nandakumar on Aug 3 2018, 4:24 PM.

Details

Summary

This has been split from https://reviews.llvm.org/D48850 to only focus on the FileCheck change.

Diff Detail

Repository
rL LLVM

Event Timeline

bogner accepted this revision.Aug 7 2018, 2:16 PM

LGTM.

include/llvm/Support/FileCheck.h
45

This name is a bit generic for the llvm:: namespace, we should probably use something with FileCheck in the name.

131

Same here.

It's a bit sad that these types need to be visible in the header, but it's kind of hard to avoid without doing something quite a bit more awkward so I guess it makes sense.

This revision is now accepted and ready to land.Aug 7 2018, 2:16 PM

Thanks for the review. I'll push after renaming the generic names.

include/llvm/Support/FileCheck.h
45

I've renamed the enums and other structs to have the prefix FileCheck in them.

Submitted in r339192