This has been split from https://reviews.llvm.org/D48850 to only focus on the FileCheck change.
Diff Detail
Diff Detail
- Repository
- rL LLVM
Event Timeline
Comment Actions
LGTM.
include/llvm/Support/FileCheck.h | ||
---|---|---|
45 | This name is a bit generic for the llvm:: namespace, we should probably use something with FileCheck in the name. | |
131 | Same here. It's a bit sad that these types need to be visible in the header, but it's kind of hard to avoid without doing something quite a bit more awkward so I guess it makes sense. |
Comment Actions
Thanks for the review. I'll push after renaming the generic names.
include/llvm/Support/FileCheck.h | ||
---|---|---|
45 | I've renamed the enums and other structs to have the prefix FileCheck in them. |
This name is a bit generic for the llvm:: namespace, we should probably use something with FileCheck in the name.