This is an archive of the discontinued LLVM Phabricator instance.

[GISel]: Testing LegalizerHelper using Unit tests
AbandonedPublic

Authored by aditya_nandakumar on Jul 2 2018, 2:34 PM.

Details

Summary

Test Legalization lowering using unit tests.
Refactor FileCheck to be used from within unit tests.

Diff Detail

Event Timeline

Conceptually this looks pretty good, but we should definitely sink a lot of this implementation into lib/Support/FileCheck.cpp and anything that stays in the header should be moved into the llvm:: namespace, since this is library code now. There are a lot of overly generic names in the implementation as is (like Pattern), which is fine as long as they end up in anonymous namespaces in FileCheck.cpp but will have to be changed if they're really part of the API.

Moved most of the implementation to lib/Support/FileCheck.cpp as requested by @bogner .

bogner added inline comments.Aug 1 2018, 1:17 PM
include/llvm/Support/FileCheck.h
1

This is missing the standard llvm header and include guards.

1–14

Please go through these and see which ones are still needed in the header. I think some of these are only needed in the .cpp file now.

51

These top level structs, enums, and classes could probably all use brief doxygen comments about what they're for.

88

It's probably cleaner to do in a separate patch (either before or after), but we might as well change these names to fit the modern llvm convention of starting with a lower case letter since we're making them public.

Split the FileCheck part to https://reviews.llvm.org/D50283 - and updated based on the feedback.

aditya_nandakumar abandoned this revision.Aug 8 2018, 3:18 PM

Abandoning this as the FIleCheck part has landed, and I've merged the legalizerHelper testing into https://reviews.llvm.org/D48847