This is an archive of the discontinued LLVM Phabricator instance.

[coroutines] Fix handling of dependent co_await in StmtProfiler
ClosedPublic

Authored by vitaut on Jul 30 2018, 12:23 PM.

Details

Summary

Fix "Invalid operator call kind" error (llvm_unreachable) in
DecodeOperatorCall when compiling the following example with -emit-pch:

struct S {};
S operator co_await(S) { return S(); }

template <typename T>
int f3(T x) {
  co_await x;
}

Add the example to PCH test cases.

Diff Detail

Repository
rL LLVM

Event Timeline

vitaut created this revision.Jul 30 2018, 12:23 PM
vitaut edited the summary of this revision. (Show Details)Jul 30 2018, 12:24 PM
vitaut edited the summary of this revision. (Show Details)
rsmith accepted this revision.Jul 30 2018, 12:40 PM

Looks good, thanks. Do you need someone to commit this for you?

This revision is now accepted and ready to land.Jul 30 2018, 12:40 PM

Do you need someone to commit this for you?

Yes, please. I don't have commit rights.

This revision was automatically updated to reflect the committed changes.