[ADT] ImmutableList::add parameters are switched

[Szelethus]

Summary

Clang side changes, see D49985.

[george.karpenkov]

I'm a bit confused: does it mean these methods are never called in Clang?

[NoQ]

Cool! Always bothered me.

In D49986#1180403, @george.karpenkov wrote:

I'm a bit confused: does it mean these methods are never called in Clang?

This patch *is* for clang.

[Szelethus]

In D49985#1181568, @NoQ wrote:

In D49985#1181564, @dblaikie wrote:

It looks like concat orders the arguments in the same way that the output would be (so concat(X, list) produces [X, list]) - so preserving that argument order seems like it improves/retains readability compared to switching them around so 'concat(list, X)' produces '[X, list]'.

Yeah, i guess that might have been the motivation behind such inconsistency. I'll be fine with fixing the order for other data structures.

@NoQ Have your views changed about this patch? Shall I abandon it?

[Szelethus]

In D49986#1192798, @Szelethus wrote:

In D49985#1181568, @NoQ wrote:

In D49985#1181564, @dblaikie wrote:

It looks like concat orders the arguments in the same way that the output would be (so concat(X, list) produces [X, list]) - so preserving that argument order seems like it improves/retains readability compared to switching them around so 'concat(list, X)' produces '[X, list]'.

Yeah, i guess that might have been the motivation behind such inconsistency. I'll be fine with fixing the order for other data structures.

@NoQ Have your views changed about this patch? Shall I abandon it?

I've decided to do so after rL340824.

include/clang/StaticAnalyzer/Core/PathSensitive/BasicValueFactory.h

const PointerToMemberData *getPointerToMemberData(
       const DeclaratorDecl *DD,
       llvm::ImmutableList<const CXXBaseSpecifier *> L);
 
   llvm::ImmutableList<SVal> getEmptySValList() {
     return SValListFactory.getEmptyList();
   }
 
   llvm::ImmutableList<SVal> prependSVal(SVal X, llvm::ImmutableList<SVal> L) {
-    return SValListFactory.add(L, X);
+    return SValListFactory.add(X, L);
   }
 
   llvm::ImmutableList<const CXXBaseSpecifier *> getEmptyCXXBaseList() {
     return CXXBaseListFactory.getEmptyList();
   }
 
   llvm::ImmutableList<const CXXBaseSpecifier *> prependCXXBase(
       const CXXBaseSpecifier *CBS,
       llvm::ImmutableList<const CXXBaseSpecifier *> L) {
-    return CXXBaseListFactory.add(L, CBS);
+    return CXXBaseListFactory.add(CBS, L);
   }
 
   const PointerToMemberData *accumCXXBase(
       llvm::iterator_range<CastExpr::path_const_iterator> PathRange,
       const nonloc::PointerToMember &PTM);
 
   const llvm::APSInt* evalAPSInt(BinaryOperator::Opcode Op,
                                      const llvm::APSInt& V1,

include/clang/StaticAnalyzer/Core/PathSensitive/ProgramStateTrait.h

namespace ento {
   // Partial-specialization for ImmutableList.
   template <typename T>
   struct ProgramStatePartialTrait<llvm::ImmutableList<T>> {
     using data_type = llvm::ImmutableList<T>;
     using key_type = T;
     using context_type = typename data_type::Factory &;
 
     static data_type Add(data_type L, key_type K, context_type F) {
-      return F.add(L, K);
+      return F.add(K, L);
     }
 
     static bool Contains(data_type L, key_type K) {
       return L.contains(K);
     }
 
     static data_type MakeData(void *const *p) {
       return p ? data_type((const llvm::ImmutableListImpl<T> *) *p)