This is an archive of the discontinued LLVM Phabricator instance.

[ADT] ImmutableList::add parameters are switched
AbandonedPublic

Authored by Szelethus on Jul 30 2018, 7:04 AM.

Details

Summary

Clang side changes, see D49985.

Diff Detail

Event Timeline

Szelethus created this revision.Jul 30 2018, 7:04 AM

I'm a bit confused: does it mean these methods are never called in Clang?

NoQ accepted this revision.Jul 30 2018, 1:24 PM

Cool! Always bothered me.

I'm a bit confused: does it mean these methods are never called in Clang?

This patch *is* for clang.

This revision is now accepted and ready to land.Jul 30 2018, 1:24 PM
In D49985#1181568, @NoQ wrote:

It looks like concat orders the arguments in the same way that the output would be (so concat(X, list) produces [X, list]) - so preserving that argument order seems like it improves/retains readability compared to switching them around so 'concat(list, X)' produces '[X, list]'.

Yeah, i guess that might have been the motivation behind such inconsistency. I'll be fine with fixing the order for other data structures.

@NoQ Have your views changed about this patch? Shall I abandon it?

Szelethus abandoned this revision.Aug 28 2018, 7:23 AM
In D49985#1181568, @NoQ wrote:

It looks like concat orders the arguments in the same way that the output would be (so concat(X, list) produces [X, list]) - so preserving that argument order seems like it improves/retains readability compared to switching them around so 'concat(list, X)' produces '[X, list]'.

Yeah, i guess that might have been the motivation behind such inconsistency. I'll be fine with fixing the order for other data structures.

@NoQ Have your views changed about this patch? Shall I abandon it?

I've decided to do so after rL340824.