Page MenuHomePhabricator

[GlobalISel] Add a G_BLOCK_ADDR opcode to handle IR blockaddress constants.
ClosedPublic

Authored by aemerson on Jul 26 2018, 7:17 PM.

Diff Detail

Repository
rL LLVM

Event Timeline

aemerson created this revision.Jul 26 2018, 7:17 PM
rtereshin accepted this revision.Jul 30 2018, 10:52 AM

Besides a nitpick, LGTM

include/llvm/CodeGen/GlobalISel/MachineIRBuilder.h
952 ↗(On Diff #157634)

If this is evident from the operand type I'd drop the comment. Could a BlockAddress be something else, not "an IR block address value"?
Just a nitpick, not blocking.

This revision is now accepted and ready to land.Jul 30 2018, 10:52 AM
aemerson added inline comments.Jul 30 2018, 11:14 AM
include/llvm/CodeGen/GlobalISel/MachineIRBuilder.h
952 ↗(On Diff #157634)

True, it's a bit redundant.

This revision was automatically updated to reflect the committed changes.