This is an archive of the discontinued LLVM Phabricator instance.

[CMake] Followup for r337366: Only export LLVM_LINK_LLVM_DYLIB it it's set to ON
ClosedPublic

Authored by philip.pfaffe on Jul 26 2018, 4:05 AM.

Details

Summary

As it was, always exporting LLVM_LINK_LLVM_DYLIB caused out-of-tree
clients to lose the ability to link against the dylib, even if in-tree tools did
not. By only exporting the setting if it is enabled, out-of-tree clients get the
correct default, but may still choose if they can.

Event Timeline

philip.pfaffe created this revision.Jul 26 2018, 4:05 AM

Since the 8.0 branch is around the corner I'd really like feedback from @beanz whether this makes sense or not.

bogner accepted this revision.Jul 26 2018, 9:44 PM

I believe this fixes the issues I was hitting.

This revision is now accepted and ready to land.Jul 26 2018, 9:44 PM
chandlerc accepted this revision.Jul 26 2018, 11:59 PM

LGTM.

After thinking more about it, this seems like the only sensible course.

Once you set this, you can't really go back, but you can delay setting it and this patch lets exactly that happen. Feel free to go ahead and submit, folks can follow-up post-commit if needed and it addresses an issue impacting Duncan and maybe others.

This revision was automatically updated to reflect the committed changes.