This is an archive of the discontinued LLVM Phabricator instance.

[CMake] Don't generate linker script only when shared library isn't statically linked
ClosedPublic

Authored by phosek on Jul 25 2018, 9:26 PM.

Details

Summary

Since r337668, we support statically linking dependencies only to shared
or static library. However, that change hasn't updated the check whether
to generate a linker script. We shouldn't generate linker script only in
the case when we aren't statically linked ABI into the shared library.

Diff Detail

Repository
rCXX libc++

Event Timeline

phosek created this revision.Jul 25 2018, 9:26 PM
EricWF accepted this revision.Jul 25 2018, 9:59 PM
This revision is now accepted and ready to land.Jul 25 2018, 9:59 PM
This revision was automatically updated to reflect the committed changes.