This is an archive of the discontinued LLVM Phabricator instance.

[libcxx] [windows] Fix warning about comparing ints of different signs
ClosedPublic

Authored by mstorsjo on Jul 25 2018, 3:33 AM.

Details

Summary

This fixes a warning like this:

warning: comparison of integers of different signs:

    'std::__1::__libcpp_tls_key' (aka 'long') and 'DWORD'
    (aka 'unsigned long') [-Wsign-compare]
if (*__key == FLS_OUT_OF_INDEXES)
    ~~~~~~ ^  ~~~~~~~~~~~~~~~~~~

Diff Detail

Repository
rL LLVM

Event Timeline

mstorsjo created this revision.Jul 25 2018, 3:33 AM
EricWF accepted this revision.Jul 25 2018, 3:43 AM

LGTM.

This revision is now accepted and ready to land.Jul 25 2018, 3:43 AM
This revision was automatically updated to reflect the committed changes.