This is an archive of the discontinued LLVM Phabricator instance.

[Fuzzer] Update path to libc++ headers
ClosedPublic

Authored by phosek on Jul 23 2018, 3:56 PM.

Details

Summary

The path to headers which are installed into libc++ build directory
has changed in r337727 which broke the libFuzzer build.

Diff Detail

Event Timeline

phosek created this revision.Jul 23 2018, 3:56 PM
Herald added subscribers: Restricted Project, llvm-commits, mgorny. · View Herald Transcript
morehouse accepted this revision.Jul 23 2018, 4:00 PM
This revision is now accepted and ready to land.Jul 23 2018, 4:00 PM

Sorry and thank you for fixing this!

Sorry and thank you for fixing this!

No problem. However, while this appears to be fixing the problem on Linux, I'm also seeing another build error on macOS, see https://logs.chromium.org/v/?s=fuchsia%2Fbuildbucket%2Fcr-buildbucket.appspot.com%2F8940172878105791200%2F%2B%2Fsteps%2Fclang%2F0%2Fsteps%2Fbuild%2F0%2Fstdout, which I don't quite understand yet because that one is failing in both libFuzzer and XRay.

I don't have any idea on that failure either. I can try a Mac build on my local mac and see what's wrong, but meanwhile do you think it'd be better to revert rL337727 for now? I'm not sure why the failure rL337727 fixed does not show up on the LLVM buildbots though (it showed up on our local builds).

I don't have any idea on that failure either. I can try a Mac build on my local mac and see what's wrong, but meanwhile do you think it'd be better to revert rL337727 for now? I'm not sure why the failure rL337727 fixed does not show up on the LLVM buildbots though (it showed up on our local builds).

I'm doing a local build on my macOS machine, let's wait if I can figure out what the problem is.

This revision was automatically updated to reflect the committed changes.

Someone reverted rL337727 in rL337782 because of the same errors you mentioned. Were you able to figure out why the errors happened?