This patch improves sched models for SHLD/SHRD* X86 instrs removing unnecessary redefinitions of instr infos. This patch is based on results of D48222.
Details
Diff Detail
Event Timeline
lib/Target/X86/X86SchedBroadwell.td | ||
---|---|---|
109 | You should be able to use the X86WriteRes multiclass for all of these (in all models) | |
1308 | Don't leave commented out entries | |
lib/Target/X86/X86ScheduleSLM.td | ||
107 | Can you fix the test changes? | |
lib/Target/X86/X86ScheduleZnver1.td | ||
179 | Why not used like the other models? |
lib/Target/X86/X86Schedule.td | ||
---|---|---|
148–151 | Can WriteShiftDouble be removed? Maybe move the new classes down here with the other shifts? |
lib/Target/X86/X86Schedule.td | ||
---|---|---|
148 | But I removed defm WriteShiftDouble : X86SchedWritePair; Why do we need the comments? | |
lib/Target/X86/X86ScheduleAtom.td | ||
153 | Are you sure? For other CPUs we have WriteSHDrri, WriteSHDrrcl,etc. for all sizes but in Atom it covers 32-bit version only. All other sizes have special redefinitions. To make this clear I put here this comment. Are you sure I have to remove it? |
Nitpicking: i wish there was some documented naming scheme.
E.g., why is this c instead of CL?