avt77 (Andrew V. Tischenko)
User

Projects

User does not belong to any projects.

User Details

User Since
Apr 11 2016, 3:46 AM (75 w, 6 d)

Recent Activity

Thu, Sep 21

avt77 closed D37292: 'into' instruction should not be decoded as valid in 64-bit mode.

r313735

Thu, Sep 21, 1:07 AM

Wed, Sep 20

avt77 committed rL313735: 'into' instruction should not be decoded as a valid instr in 64-bit mode.
'into' instruction should not be decoded as a valid instr in 64-bit mode
Wed, Sep 20, 1:18 AM

Tue, Sep 19

avt77 updated the diff for D37262: The issues with X86 prefixes: step 2.

I fixed issues raised by Craig and Simon.

Tue, Sep 19, 3:58 AM
avt77 abandoned D34056: Tail merge size.

It seems nobody wants to change the default value of the switch.

Tue, Sep 19, 3:45 AM
avt77 abandoned D36788: The issues with X86 prefixes.

D37262 covers all issues from this review plus some others that's why we don't need D36788 any more.

Tue, Sep 19, 3:43 AM
avt77 updated the diff for D37292: 'into' instruction should not be decoded as valid in 64-bit mode.

I re-implemented the fix accordingly to Craig suggest.

Tue, Sep 19, 3:17 AM

Wed, Aug 30

avt77 added reviewers for D37292: 'into' instruction should not be decoded as valid in 64-bit mode: RKSimon, craig.topper, echristo, davide, dtemirbulatov.
Wed, Aug 30, 4:32 AM
avt77 created D37292: 'into' instruction should not be decoded as valid in 64-bit mode.
Wed, Aug 30, 4:29 AM

Tue, Aug 29

avt77 created D37262: The issues with X86 prefixes: step 2.
Tue, Aug 29, 6:46 AM

Mon, Aug 28

avt77 committed rL311882: The current version of LLVM X86 disassembler incorrectly interprets some….
The current version of LLVM X86 disassembler incorrectly interprets some…
Mon, Aug 28, 3:44 AM
avt77 closed D36788: The issues with X86 prefixes by committing rL311882: The current version of LLVM X86 disassembler incorrectly interprets some….
Mon, Aug 28, 3:44 AM

Aug 25 2017

avt77 updated the diff for D36788: The issues with X86 prefixes.

32-bit tests added and the condition fixed properly.

Aug 25 2017, 7:53 AM
avt77 added inline comments to D36788: The issues with X86 prefixes.
Aug 25 2017, 2:25 AM

Aug 23 2017

avt77 updated the diff for D36788: The issues with X86 prefixes.

Craig's issues fixed.

Aug 23 2017, 3:09 AM
avt77 added inline comments to D36788: The issues with X86 prefixes.
Aug 23 2017, 12:47 AM

Aug 22 2017

avt77 abandoned D36735: Clang changes related to D35621.

https://reviews.llvm.org/D36793 should cover these issues

Aug 22 2017, 4:27 AM
avt77 abandoned D35621: X86 Asm can't work properly with symbolic Scale.

All changes from this review (excluding error diagnostic) were included in D36793.

Aug 22 2017, 4:18 AM
avt77 updated the diff for D36788: The issues with X86 prefixes.

I did fixes raised by Craig.

Aug 22 2017, 2:52 AM

Aug 18 2017

avt77 added a comment to D36793: [X86AsmParser] Refactoring, (almost) NFC..

IntelExpr::isValid looks rather strange because it validates possible multiplication only. But if we have Scale == 1 and don't have either BaseReg or Disp?

Aug 18 2017, 3:37 AM
avt77 added a comment to D35621: X86 Asm can't work properly with symbolic Scale.

+ I'm currently having a patch on review (D36793) which contains most of the intended goals of this one (everything but the new error, afaik), can you verify it answers your needs?

Yes, I see that everything I need here is included in D36793. When are you going to commit it? BTW, I have some questions about D36793 but I'll include them in that review.

Aug 18 2017, 3:26 AM
avt77 added a comment to D35621: X86 Asm can't work properly with symbolic Scale.

Coby, Reid, is eveything OK? Could you get LGTM?

Aug 18 2017, 12:50 AM

Aug 16 2017

avt77 updated the diff for D36788: The issues with X86 prefixes.

I fixed the last minute issue raised in the first version.

Aug 16 2017, 7:54 AM
avt77 added a comment to D36788: The issues with X86 prefixes.

I found one issue in the current version of the patch that's why I'm asking to postpone its review until the next version: hope to publish it in some hours or tomorrow.

Aug 16 2017, 6:26 AM
avt77 created D36788: The issues with X86 prefixes.
Aug 16 2017, 5:52 AM
avt77 updated the diff for D35621: X86 Asm can't work properly with symbolic Scale.

Aplied Reid's requirements.

Aug 16 2017, 3:18 AM

Aug 15 2017

avt77 abandoned D35202: [X86] lea rdx, [rax - one] adds one instead of subtracts when one is a symbol that has been .set (PR33667).

It's fixed in D35621

Aug 15 2017, 8:04 AM
avt77 added a comment to D35621: X86 Asm can't work properly with symbolic Scale.

I created a ne review to show changes in Clang: D36735

Aug 15 2017, 6:32 AM
avt77 created D36735: Clang changes related to D35621.
Aug 15 2017, 6:28 AM
avt77 updated the diff for D35621: X86 Asm can't work properly with symbolic Scale.

I restored the patch with LLVM part only.

Aug 15 2017, 6:25 AM
avt77 updated the diff for D35621: X86 Asm can't work properly with symbolic Scale.

The Clang changes added.

Aug 15 2017, 5:12 AM
avt77 updated the diff for D35621: X86 Asm can't work properly with symbolic Scale.

Last minor fixes done.

Aug 15 2017, 5:10 AM

Aug 14 2017

avt77 updated the diff for D35621: X86 Asm can't work properly with symbolic Scale.

I removed all changes (apart from the added diagnostics). Now it should fit to Coby requirements. Right?

Aug 14 2017, 2:53 AM

Aug 11 2017

avt77 updated the diff for D35621: X86 Asm can't work properly with symbolic Scale.

I applied all changes suggested by Coby.

Aug 11 2017, 3:23 AM

Aug 10 2017

avt77 added inline comments to D35621: X86 Asm can't work properly with symbolic Scale.
Aug 10 2017, 4:30 AM
avt77 added inline comments to D35621: X86 Asm can't work properly with symbolic Scale.
Aug 10 2017, 3:43 AM
avt77 added inline comments to D35621: X86 Asm can't work properly with symbolic Scale.
Aug 10 2017, 3:41 AM

Aug 8 2017

avt77 updated the diff for D35621: X86 Asm can't work properly with symbolic Scale.

The last requirements from Simon were fixed.

Aug 8 2017, 2:16 AM
avt77 added inline comments to D35621: X86 Asm can't work properly with symbolic Scale.
Aug 8 2017, 12:50 AM

Aug 4 2017

avt77 updated the diff for D35621: X86 Asm can't work properly with symbolic Scale.

Hope, my comments now are OK.

Aug 4 2017, 7:29 AM
avt77 abandoned D33991: Improved throughput calculation.

There were 2 commits covering this patch

Aug 4 2017, 3:48 AM
avt77 added a comment to D33991: Improved throughput calculation.

I'm not sure we need rebase this patch because 2 pre-patches do almost everything I'd like to see here. There is only one last thing: a possibilty to return latency as value of throughput if we don't have any sched model or don't have ResourceCycles in the existing model. But now I think that programmer can do this functionality by himself (if s/he needs it). Am I right? I'm going to abandon this review. OK?

Aug 4 2017, 3:29 AM
avt77 added inline comments to D35621: X86 Asm can't work properly with symbolic Scale.
Aug 4 2017, 3:13 AM
avt77 added inline comments to D35621: X86 Asm can't work properly with symbolic Scale.
Aug 4 2017, 1:58 AM

Aug 3 2017

avt77 added a comment to D35621: X86 Asm can't work properly with symbolic Scale.

Hi Reviewers?
Do you have any questions about this patch?

Aug 3 2017, 2:39 AM

Aug 1 2017

avt77 committed rL309666: Support itineraries in TargetSubtargetInfo::getSchedInfoStr - Now if the given….
Support itineraries in TargetSubtargetInfo::getSchedInfoStr - Now if the given…
Aug 1 2017, 2:16 AM

Jul 31 2017

avt77 updated the diff for D35997: Support itineraries in TargetSubtargetInfo::getSchedInfoStr.

The note mentioned by Simon fixed.

Jul 31 2017, 4:19 AM

Jul 28 2017

avt77 created D35997: Support itineraries in TargetSubtargetInfo::getSchedInfoStr.
Jul 28 2017, 7:10 AM
avt77 closed D35831: Don't use std::numeric_limits<double>::infinity() as result of function.

It was committed

Jul 28 2017, 6:59 AM

Jul 27 2017

avt77 added a comment to D29402: [SLP] Initial rework for min/max horizontal reduction vectorization, NFC..

Could we split it on 2 sub-parts:

Jul 27 2017, 8:40 AM
avt77 committed rL309269: Added cost of ZEROALL and ZEROUPPER instrs in btver2 cpu..
Added cost of ZEROALL and ZEROUPPER instrs in btver2 cpu.
Jul 27 2017, 6:12 AM

Jul 26 2017

avt77 committed rL309156: This patch returns proper value to indicate the case when instruction….
This patch returns proper value to indicate the case when instruction…
Jul 26 2017, 11:56 AM
avt77 updated the diff for D35831: Don't use std::numeric_limits<double>::infinity() as result of function.

The questionn with getCycles() fixed.

Jul 26 2017, 9:34 AM
avt77 updated the diff for D35831: Don't use std::numeric_limits<double>::infinity() as result of function.

I got rid of "double Unknown = std::numeric_limits<double>::infinity();" - many tnx to Simon for this idea.

Jul 26 2017, 7:08 AM
avt77 updated the diff for D35621: X86 Asm can't work properly with symbolic Scale.

I re-based the the code after the patch about replacing of assertions with corresponding diagnostic error messages. As result changes in tests show that X86 Asm supports symbolic Scale/Disp properly now (including its negative value).

Jul 26 2017, 7:01 AM

Jul 25 2017

avt77 committed rL308972: X86 Asm uses assertions instead of proper diagnostic. This patch fixes that..
X86 Asm uses assertions instead of proper diagnostic. This patch fixes that.
Jul 25 2017, 6:06 AM
avt77 closed D35115: X86 Asm should produce error messages instead of assertions when it's possible by committing rL308972: X86 Asm uses assertions instead of proper diagnostic. This patch fixes that..
Jul 25 2017, 6:06 AM
avt77 created D35834: VZEROUPPER and VZEROALL in btver2 schedule model.
Jul 25 2017, 5:55 AM
avt77 created D35831: Don't use std::numeric_limits<double>::infinity() as result of function.
Jul 25 2017, 5:17 AM

Jul 21 2017

avt77 updated the diff for D35115: X86 Asm should produce error messages instead of assertions when it's possible.

This patch replaces assertions with normal diagnostic when it's possible. Now we see normal error messages instead of compiler crashes. It should close PR33861, PR33862 and PR33661. In addition the patch prepares tests for D35621.

Jul 21 2017, 8:13 AM

Jul 20 2017

avt77 updated the diff for D35621: X86 Asm can't work properly with symbolic Scale.

I updated 2 tests in trunk to demonstarte the difference in code generation after this patch aplying. Now we can clearly see the issues and how they could be resolved with help of this patch.

Jul 20 2017, 7:46 AM
avt77 committed rL308609: This patch added some test cases to demonsrate the issues described in Bug….
This patch added some test cases to demonsrate the issues described in Bug…
Jul 20 2017, 5:46 AM

Jul 19 2017

avt77 created D35621: X86 Asm can't work properly with symbolic Scale.
Jul 19 2017, 7:22 AM

Jul 14 2017

avt77 added inline comments to D35115: X86 Asm should produce error messages instead of assertions when it's possible.
Jul 14 2017, 1:47 AM
avt77 updated the diff for D35202: [X86] lea rdx, [rax - one] adds one instead of subtracts when one is a symbol that has been .set (PR33667).

I fixed Simon's comments.

Jul 14 2017, 1:43 AM

Jul 13 2017

avt77 updated the diff for D33099: [X86] Model 256-bit AVX instructions in the AMD Jaguar scheduler (PR28573).

I merged this patch with trunk. Now it's a part 2 othe initial patch.

Jul 13 2017, 11:57 PM

Jul 11 2017

avt77 added inline comments to D35115: X86 Asm should produce error messages instead of assertions when it's possible.
Jul 11 2017, 8:21 AM
avt77 added inline comments to D35115: X86 Asm should produce error messages instead of assertions when it's possible.
Jul 11 2017, 3:43 AM

Jul 10 2017

avt77 committed rL307552: [X86] Model 256-bit AVX instructions in the AMD Jaguar scheduler Part-1….
[X86] Model 256-bit AVX instructions in the AMD Jaguar scheduler Part-1…
Jul 10 2017, 9:36 AM
avt77 closed D35198: [X86] Model 256-bit AVX instructions in the AMD Jaguar scheduler Part-1 by committing rL307552: [X86] Model 256-bit AVX instructions in the AMD Jaguar scheduler Part-1….
Jul 10 2017, 9:36 AM
avt77 created D35202: [X86] lea rdx, [rax - one] adds one instead of subtracts when one is a symbol that has been .set (PR33667).
Jul 10 2017, 8:37 AM
avt77 created D35198: [X86] Model 256-bit AVX instructions in the AMD Jaguar scheduler Part-1 .
Jul 10 2017, 6:07 AM

Jul 7 2017

avt77 updated the diff for D35115: X86 Asm should produce error messages instead of assertions when it's possible.

I removed NFCs from this patch.

Jul 7 2017, 7:55 AM
avt77 committed rL307397: NFC: I simply added CHECK-LABEL to prevent false matches in the tests..
NFC: I simply added CHECK-LABEL to prevent false matches in the tests.
Jul 7 2017, 6:42 AM
avt77 updated the diff for D33099: [X86] Model 256-bit AVX instructions in the AMD Jaguar scheduler (PR28573).

Simon, thank you for all these catches: I fixed them.

Jul 7 2017, 4:00 AM
avt77 created D35115: X86 Asm should produce error messages instead of assertions when it's possible.
Jul 7 2017, 3:20 AM

Jul 6 2017

avt77 retitled D33099: [X86] Model 256-bit AVX instructions in the AMD Jaguar scheduler (PR28573) from AMD Jaguar scheduler doesn't correctly model 256-bit AVX instructions to [X86] Model 256-bit AVX instructions in the AMD Jaguar scheduler (PR28573).
Jul 6 2017, 7:24 AM
avt77 updated the diff for D33099: [X86] Model 256-bit AVX instructions in the AMD Jaguar scheduler (PR28573).

We have now only 256-bit ops: it makes the patch smaller.

Jul 6 2017, 2:59 AM

Jun 13 2017

avt77 updated the diff for D34056: Tail merge size.

The comments fixed.
New reviewers added.

Jun 13 2017, 9:26 AM

Jun 9 2017

avt77 created D34056: Tail merge size.
Jun 9 2017, 9:01 AM

Jun 8 2017

avt77 committed rL304986: Add scheduler classes to integer/float horizontal operations..
Add scheduler classes to integer/float horizontal operations.
Jun 8 2017, 9:44 AM
avt77 closed D33203: Add scheduler classes to integer/float horizontal operations by committing rL304986: Add scheduler classes to integer/float horizontal operations..
Jun 8 2017, 9:44 AM
avt77 updated the diff for D33099: [X86] Model 256-bit AVX instructions in the AMD Jaguar scheduler (PR28573).

All notes from Simon were resolved. In addition I fixed numbers for some XMM versions of VMOVxxxx instructions.

Jun 8 2017, 7:22 AM
avt77 added inline comments to D33099: [X86] Model 256-bit AVX instructions in the AMD Jaguar scheduler (PR28573).
Jun 8 2017, 4:41 AM
avt77 updated the diff for D33203: Add scheduler classes to integer/float horizontal operations.

Some renames and other minor updates.

Jun 8 2017, 3:48 AM
avt77 committed rL304972: This patch closes PR28513: an optimization of multiplication by different….
This patch closes PR28513: an optimization of multiplication by different…
Jun 8 2017, 3:20 AM

Jun 7 2017

avt77 created D33991: Improved throughput calculation.
Jun 7 2017, 6:55 AM
avt77 updated the diff for D33099: [X86] Model 256-bit AVX instructions in the AMD Jaguar scheduler (PR28573).

I removed all changes related to throughput calculations. And I made all updates suggested by Simon.

Jun 7 2017, 5:50 AM
avt77 updated the diff for D33203: Add scheduler classes to integer/float horizontal operations.

I re-implemented all things mentioned by Simon and Gadi.

Jun 7 2017, 2:46 AM

Jun 6 2017

avt77 added a comment to D33897: [X86][SandyBridge,Haswell] Updating information on each instruction in HSW and SNB about latency, number of uOps and used ports.

Why don't you use regular expressions instead of simple list of instructions?

Jun 6 2017, 6:36 AM

Jun 1 2017

avt77 updated the diff for D33203: Add scheduler classes to integer/float horizontal operations.

I removed default values defined for SB model (required by javed.absar).

Jun 1 2017, 9:14 AM
avt77 updated the diff for D33203: Add scheduler classes to integer/float horizontal operations.

I fixed all Simon's notes.

Jun 1 2017, 9:01 AM
avt77 added a comment to D33099: [X86] Model 256-bit AVX instructions in the AMD Jaguar scheduler (PR28573).

I really don't understand why you are having to change the throughput calculation as part of this - split this as another patch?

Jun 1 2017, 5:53 AM
avt77 added inline comments to D33203: Add scheduler classes to integer/float horizontal operations.
Jun 1 2017, 5:47 AM
avt77 added inline comments to D33203: Add scheduler classes to integer/float horizontal operations.
Jun 1 2017, 5:43 AM

May 30 2017

avt77 closed D32352: Go to eleven.

Committed revision 304209

May 30 2017, 6:01 AM
avt77 committed rL304209: This patch closes PR28513: an optimization of multiplication by different….
This patch closes PR28513: an optimization of multiplication by different…
May 30 2017, 6:01 AM
avt77 updated the diff for D33203: Add scheduler classes to integer/float horizontal operations.

I redesigned the implementation accordingly to Simon requirements. Now it's done in general way and every X86 should support horizontal operations modeling. I did not check the numbers for SB and SLM: I simply kept the current ones. And I separated Ymm version from Xmm version to be able to model the corresponding throughput difference for Jaguar.

May 30 2017, 3:42 AM

May 29 2017

avt77 closed D32218: X86AsmParser.cpp asserts: OperandStack.size() > 1 && "Too few operands.".

The revision was committed.

May 29 2017, 7:29 AM

May 26 2017

avt77 committed rL303985: The fix for PR22004: X86AsmParser.cpp asserts: OperandStack.size() > 1 && "Too….
The fix for PR22004: X86AsmParser.cpp asserts: OperandStack.size() > 1 && "Too…
May 26 2017, 6:23 AM

May 25 2017

avt77 updated the diff for D32352: Go to eleven.

Hi All,
I merged with trunk and launched "check-all": everything works without any issue.
Craig, Zvi - could you give me LGTM?

May 25 2017, 8:17 AM