This is an archive of the discontinued LLVM Phabricator instance.

[mips] Fix compile options for tramp3d-v4 test
ClosedPublic

Authored by abeserminji on Jul 18 2018, 8:08 AM.

Download Raw Diff

Details

Reviewers

atanasyan
petarj
mstojanovic

Commits

rOLDT338581: [mips] Fix compile options for tramp3d-v4 test
rL338581: [mips] Fix compile options for tramp3d-v4 test

Summary

Add -mxgot to CPP flags, because for this test, GOT grows larger than 64k.

Diff Detail

Repository: rL LLVM

Event Timeline

abeserminji created this revision.Jul 18 2018, 8:08 AM

Herald added subscribers: arichardson, sdardis. · View Herald TranscriptJul 18 2018, 8:08 AM

atanasyan added inline comments.Jul 19 2018, 3:15 AM

MultiSource/Benchmarks/tramp3d-v4/Makefile
17 ↗	(On Diff #156072)	Does a linker fails without this option? Usually a linker automatically starts to create multi-GOT if a regular single GOT is overflowed. It's interesting if this option does not work in that case.

abeserminji added inline comments.Jul 19 2018, 3:57 AM

MultiSource/Benchmarks/tramp3d-v4/Makefile
17 ↗	(On Diff #156072)	Yes it does, with this error: additional relocation overflows omitted from the output

atanasyan added inline comments.Jul 19 2018, 4:12 AM

MultiSource/Benchmarks/tramp3d-v4/Makefile
17 ↗	(On Diff #156072)	Interesting. What options do you use to build the test case: 32/64 static/dynamic etc?

The test fail can be reproduced by running optimization level -O0 or -O1 with mips64r6 n64. Both big- and little-endian fail.

I forget that tramp3d-v4 test case consists a single file and this file is big enough. Could you apply the same changes to the CMakeLists.txt?

Comments addressed.

Herald added a subscriber: mgorny. · View Herald TranscriptAug 1 2018, 8:08 AM

LGTM

This revision is now accepted and ready to land.Aug 1 2018, 8:15 AM

Closed by commit rL338581: [mips] Fix compile options for tramp3d-v4 test (authored by abeserminji). · Explain WhyAug 1 2018, 9:22 AM

This revision was automatically updated to reflect the committed changes.

Revision Contents

Path

Size

test-suite/

trunk/

MultiSource/

Benchmarks/

tramp3d-v4/

CMakeLists.txt

3 lines

Makefile

1 line

Diff 158553

test-suite/trunk/MultiSource/Benchmarks/tramp3d-v4/CMakeLists.txt

	set(PROG tramp3d-v4)			set(PROG tramp3d-v4)
	list(APPEND CXXFLAGS -fno-exceptions)			list(APPEND CXXFLAGS -fno-exceptions)
	list(APPEND LDFLAGS -lstdc++)			list(APPEND LDFLAGS -lstdc++)
	if(SMALL_PROBLEM_SIZE)			if(SMALL_PROBLEM_SIZE)
	set(RUN_OPTIONS --cartvis 1.0 0.0 --rhomin 1e-8 -n 4 --domain 32 32 32)			set(RUN_OPTIONS --cartvis 1.0 0.0 --rhomin 1e-8 -n 4 --domain 32 32 32)
	else()			else()
	set(RUN_OPTIONS --cartvis 1.0 0.0 --rhomin 1e-8 -n 10 --domain 32 32 32)			set(RUN_OPTIONS --cartvis 1.0 0.0 --rhomin 1e-8 -n 10 --domain 32 32 32)
	endif()			endif()
				if("${ARCH}" STREQUAL "Mips")
				list(APPEND CXXFLAGS -mxgot)
				endif()
	set(FP_ABSTOLERANCE 0.0000001)			set(FP_ABSTOLERANCE 0.0000001)
	llvm_multisource()			llvm_multisource()

test-suite/trunk/MultiSource/Benchmarks/tramp3d-v4/Makefile

	LEVEL = ../../..			LEVEL = ../../..

	PROG = tramp3d-v4			PROG = tramp3d-v4
	CPPFLAGS = -fno-exceptions			CPPFLAGS = -fno-exceptions
	LDFLAGS = -lstdc++			LDFLAGS = -lstdc++
	ifdef SMALL_PROBLEM_SIZE			ifdef SMALL_PROBLEM_SIZE
	RUN_OPTIONS = --cartvis 1.0 0.0 --rhomin 1e-8 -n 4 --domain 32 32 32			RUN_OPTIONS = --cartvis 1.0 0.0 --rhomin 1e-8 -n 4 --domain 32 32 32
	else			else
	RUN_OPTIONS = --cartvis 1.0 0.0 --rhomin 1e-8 -n 10 --domain 32 32 32			RUN_OPTIONS = --cartvis 1.0 0.0 --rhomin 1e-8 -n 10 --domain 32 32 32
	endif			endif
	FP_ABSTOLERANCE := 0.0000001			FP_ABSTOLERANCE := 0.0000001

	ifeq ($(ARCH),Mips)			ifeq ($(ARCH),Mips)
	# Mips needs a bit more compilation time when Mips64r6 and MSA are used			# Mips needs a bit more compilation time when Mips64r6 and MSA are used
	# together.			# together.
	RUNTIMELIMIT := 700			RUNTIMELIMIT := 700
				CPPFLAGS := "-mxgot"
	endif			endif

	include ../../Makefile.multisrc			include ../../Makefile.multisrc