This is an archive of the discontinued LLVM Phabricator instance.

[libFuzzer] Use separate test directory for each config
ClosedPublic

Authored by jdenny on Jul 12 2018, 9:44 AM.

Details

Summary

Previously, check-all failed many tests for me. It was running the
X86_64DefaultLinuxConfig, X86_64LibcxxLinuxConfig, and
X86_64StaticLibcxxLinuxConfig configs out of
llvm-build/projects/compiler-rt/test/fuzzer. Now, it runs them out of
separate subdirectories there, and most tests pass.

Diff Detail

Repository
rL LLVM

Event Timeline

jdenny created this revision.Jul 12 2018, 9:44 AM
Herald added a subscriber: Restricted Project. · View Herald TranscriptJul 12 2018, 9:44 AM
kcc edited reviewers, added: morehouse; removed: samsonov.Jul 12 2018, 6:18 PM

The other test configs don't define config.test_exec_root at all. Do we need it?

@morehouse unit tests for other sanitizers do though.
I'm a bit confused on what exactly is happening here, and why tests pass on other platforms

The other test configs don't define config.test_exec_root at all. Do we need it?

It seems we don't. I removed it, and the tests pass. I'll upload a new patch.

@morehouse unit tests for other sanitizers do though.
I'm a bit confused on what exactly is happening here,

The same tests were being run for different configs, which thus shared output files. By setting different directories for different configs, they no longer share output files.

and why tests pass on other platforms

I haven't explored other platforms. Do they ever support multiple conflicting configs (like X86_64DefaultLinuxConfig and X86_64LibcxxLinuxConfig)?

jdenny updated this revision to Diff 156318.Jul 19 2018, 10:51 AM

Removed config.test_exec_root, which is unique to each config by default.

morehouse accepted this revision.Jul 19 2018, 11:03 AM

Please watch the bots after landing this.

This revision is now accepted and ready to land.Jul 19 2018, 11:03 AM
jdenny edited the summary of this revision. (Show Details)Jul 19 2018, 11:11 AM
This revision was automatically updated to reflect the committed changes.