As disscussed in https://reviews.llvm.org/D49179#1158957 and later,
the IR can be improved:
https://rise4fun.com/Alive/gBf
But as it looks from these tests,
i think we want to revert at least some cases in DAGCombine.
Paths
| Differential D49247
[NFC][X86][AArch64] Add tests for the 'check for [no] signed truncation' pattern ClosedPublic Authored by lebedev.ri on Jul 12 2018, 9:21 AM.
Details
Summary As disscussed in https://reviews.llvm.org/D49179#1158957 and later, But as it looks from these tests,
Diff Detail
Event TimelineComment Actions LGTM - one possible improvement inline.
This revision is now accepted and ready to land.Jul 12 2018, 9:47 AM Comment Actions nounwind, fix some function names.
Closed by commit rL336917: [NFC][X86][AArch64] Add tests for the 'check for [no] signed truncation' pattern (authored by lebedevri). · Explain WhyJul 12 2018, 10:05 AM This revision was automatically updated to reflect the committed changes.
Revision Contents
Diff 155207 llvm/trunk/test/CodeGen/AArch64/lack-of-signed-truncation-check.ll
llvm/trunk/test/CodeGen/AArch64/signed-truncation-check.ll
llvm/trunk/test/CodeGen/X86/lack-of-signed-truncation-check.ll
llvm/trunk/test/CodeGen/X86/signed-truncation-check.ll
|