Page MenuHomePhabricator

[NFC][X86][AArch64] Add tests for the 'check for [no] signed truncation' pattern
ClosedPublic

Authored by lebedev.ri on Jul 12 2018, 9:21 AM.

Diff Detail

Repository
rL LLVM

Event Timeline

lebedev.ri created this revision.Jul 12 2018, 9:21 AM
spatel accepted this revision.Jul 12 2018, 9:47 AM

LGTM - one possible improvement inline.

test/CodeGen/X86/lack-of-signed-truncation-check.ll
382–384 ↗(On Diff #155194)

Add 'nounwind' attr to avoid the .cfi noise? Should probably do that for all x86 for consistency.

This revision is now accepted and ready to land.Jul 12 2018, 9:47 AM

nounwind, fix some function names.

test/CodeGen/X86/lack-of-signed-truncation-check.ll
382–384 ↗(On Diff #155194)

Oh, forgot about that..

This revision was automatically updated to reflect the committed changes.