[InstCombine] Fold x & (-1 >> y) != x to x u> (-1 >> y)
ClosedPublic

Authored by lebedev.ri on Wed, Jul 11, 2:38 PM.

Details

Summary

A complementary fold to D49179.

https://bugs.llvm.org/show_bug.cgi?id=38123
https://rise4fun.com/Alive/Rny

Caveat: one more thing in test/Transforms/InstCombine/icmp-logical.ll breaks.

Diff Detail

Repository
rL LLVM
spatel accepted this revision.Thu, Jul 12, 6:38 AM

LGTM - unless you have questions/concerns, I think it's fine if you want to continue enhancing this fold without pre-commit review. You've already done the hard part of writing the proofs and regression tests. :)

This revision is now accepted and ready to land.Thu, Jul 12, 6:38 AM

LGTM

Thank you for the review.

  • unless you have questions/concerns, I think it's fine if you want to continue enhancing this fold without pre-commit review. You've already done the hard part of writing the proofs and regression tests. :)

The other 4(?) patterns here will be non-commutative, so i'm not sure how those will go yet..

This revision was automatically updated to reflect the committed changes.