Page MenuHomePhabricator

[CMake] Give lldb tools functional install targets when building LLDB.framework
ClosedPublic

Authored by xiaobai on Jul 6 2018, 11:26 AM.

Details

Summary

This change makes the install targets for lldb tools functional when
building for the framework.

I am currently working on the install rules for lldb-framework and this will
let me make install-lldb-framework rely on install-lldb-argdumper for
instance. This is especially important for install-lldb-framework-stripped. It
is much better for install-lldb-framework-stripped to rely on
install-lldb-argdumper-stripped than to copy and strip lldb-argdumper
manually.

Event Timeline

xiaobai created this revision.Jul 6 2018, 11:26 AM

I tested this by invoking cmake with -DLLDB_BUILD_FRAMEWORK=1 and -DCMAKE_INSTALL_PREFIX="", followed by DESTDIR=/tmp ninja install-lldb-argdumper. It installed lldb-argdumper to /tmp/Library/Frameworks/LLDB.framework/Versions/A/Resources/lldb-argdumper

labath accepted this revision.Jul 16 2018, 8:20 AM

Makes sense to me.

This revision is now accepted and ready to land.Jul 16 2018, 8:20 AM
This revision was automatically updated to reflect the committed changes.