[CMake] Give lldb tools functional install targets when building LLDB.framework

[xiaobai]

Summary

This change makes the install targets for lldb tools functional when
building for the framework.

I am currently working on the install rules for lldb-framework and this will
let me make install-lldb-framework rely on install-lldb-argdumper for
instance. This is especially important for install-lldb-framework-stripped. It
is much better for install-lldb-framework-stripped to rely on
install-lldb-argdumper-stripped than to copy and strip lldb-argdumper
manually.

[xiaobai]

I tested this by invoking cmake with -DLLDB_BUILD_FRAMEWORK=1 and -DCMAKE_INSTALL_PREFIX="", followed by DESTDIR=/tmp ninja install-lldb-argdumper. It installed lldb-argdumper to /tmp/Library/Frameworks/LLDB.framework/Versions/A/Resources/lldb-argdumper

[labath]

Makes sense to me.

cmake/modules/AddLLDB.cmake

if(LLDB_BUILD_FRAMEWORK)
         set(resource_dir "/Resources")
         set(resource_dots "../")
       endif()
       string(REGEX REPLACE "[^/]+" ".." _dots ${LLDB_FRAMEWORK_INSTALL_DIR})
       set_target_properties(${name} PROPERTIES
             RUNTIME_OUTPUT_DIRECTORY $<TARGET_FILE_DIR:liblldb>${resource_dir}
             BUILD_WITH_INSTALL_RPATH On
             INSTALL_RPATH "@loader_path/../../../${resource_dots}${_dots}/${LLDB_FRAMEWORK_INSTALL_DIR}")
-      # For things inside the framework we don't need functional install targets
-      # because CMake copies the resources and headers from the build directory.
-      # But we still need this target to exist in order to use the
-      # LLVM_DISTRIBUTION_COMPONENTS build option. We also need the
-      # install-liblldb target to depend on this tool, so that it gets put into
-      # the Resources directory before the framework is installed.
-      if(ARG_GENERATE_INSTALL)
-        add_custom_target(install-${name} DEPENDS ${name})
-        add_dependencies(install-liblldb ${name})
-        add_custom_target(install-${name}-stripped DEPENDS ${name})
-        add_dependencies(install-liblldb-stripped ${name})
-      endif()
     endif()
   endif()
 
   if(LLDB_BUILD_FRAMEWORK AND NOT ARG_INCLUDE_IN_SUITE)
     set_target_properties(${name} PROPERTIES
           BUILD_WITH_INSTALL_RPATH On
           INSTALL_RPATH "@loader_path/../${LLDB_FRAMEWORK_INSTALL_DIR}")
   endif()
 
-  if(ARG_GENERATE_INSTALL AND NOT (ARG_INCLUDE_IN_SUITE AND LLDB_BUILD_FRAMEWORK ))
+  if(ARG_GENERATE_INSTALL)
+    set(out_dir "bin")
+    if (LLDB_BUILD_FRAMEWORK AND ARG_INCLUDE_IN_SUITE)
+      set(out_dir ${LLDB_FRAMEWORK_INSTALL_DIR}/${LLDB_FRAMEWORK_RESOURCE_DIR})
+    endif()
     install(TARGETS ${name}
           COMPONENT ${name}
-          RUNTIME DESTINATION bin)
+          RUNTIME DESTINATION ${out_dir})
     if (NOT CMAKE_CONFIGURATION_TYPES)
       add_llvm_install_targets(install-${name}
                                DEPENDS ${name}
                                COMPONENT ${name})
     endif()
   endif()
 
   if(ARG_INCLUDE_IN_SUITE AND LLDB_BUILD_FRAMEWORK)