This is an archive of the discontinued LLVM Phabricator instance.

Paths

Table of Contentst

-
tools/lld/
-
lld/
-
lld.cpp

Differential D48838

Add wasm-ld to help text
ClosedPublic

Authored by sbc100 on Jul 2 2018, 9:37 AM.

Download Raw Diff

Details

Reviewers

Commits

rGc4c3633a3854: Add wasm-ld to help text Improve error text
rL337300: Add wasm-ld to help text Improve error text
rLLD337300: Add wasm-ld to help text Improve error text

Diff Detail

Repository: rLLD LLVM Linker

Event Timeline

sbc100 created this revision.Jul 2 2018, 9:37 AM

Herald added subscribers: llvm-commits, sunfish, aheejin, dschuff. · View Herald TranscriptJul 2 2018, 9:37 AM

Harbormaster completed remote builds in B19945: Diff 153741.Jul 2 2018, 9:37 AM

sbc100 retitled this revision from Add wasm-ld to help text Improve error text to Add wasm-ld to help text.Jul 2 2018, 9:38 AM

sbc100 added a reviewer: ruiu.

I think there's no reason to use -flavor anymore, so I think it is deprecated. Any reason to mention that in the error message?

feedback

Harbormaster completed remote builds in B20419: Diff 155772.Jul 16 2018, 3:33 PM

This revision was not accepted when it landed; it landed in state Needs Review.Jul 17 2018, 9:39 AM

Closed by commit rLLD337300: Add wasm-ld to help text Improve error text (authored by sbc). · Explain Why

This revision was automatically updated to reflect the committed changes.

Revision Contents

Path

Size

tools/

lld/

3 lines

Diff 155905

tools/lld/lld.cpp

	Show First 20 Lines • Show All 132 Lines • ▼ Show 20 Lines		int main(int Argc, const char **Argv) {
	case WinLink:			case WinLink:
	return !coff::link(Args, canExitEarly());			return !coff::link(Args, canExitEarly());
	case Darwin:			case Darwin:
	return !mach_o::link(Args, canExitEarly());			return !mach_o::link(Args, canExitEarly());
	case Wasm:			case Wasm:
	return !wasm::link(Args, canExitEarly());			return !wasm::link(Args, canExitEarly());
	default:			default:
	die("lld is a generic driver.\n"			die("lld is a generic driver.\n"
	"Invoke ld.lld (Unix), ld64.lld (macOS) or lld-link (Windows) instead.");			"Invoke ld.lld (Unix), ld64.lld (macOS), lld-link (Windows), wasm-lld"
				" (WebAssembly) instead");
	}			}
	}			}