This is an archive of the discontinued LLVM Phabricator instance.

[LTO] Errors in LLVM backend should manifest as lld errors
ClosedPublic

Authored by sbc100 on Jul 1 2018, 3:34 PM.

Diff Detail

Repository
rL LLVM

Event Timeline

sbc100 created this revision.Jul 1 2018, 3:34 PM
sbc100 added a reviewer: pcc.Jul 1 2018, 3:34 PM

This change causes: test/ELF/lto/sample-profile.ll to fail with:

ld.lld: error: /dev/null: Could not open profile: Unrecognized sample profile encoding format

This seems like it really is an error so we should probably update the test but I'm not sure exactly what the intent of that particular test is.

sbc100 added a reviewer: ruiu.Jul 2 2018, 9:33 AM
sbc100 updated this revision to Diff 153751.Jul 2 2018, 10:13 AM
  • fix elf test
pcc accepted this revision.Jul 2 2018, 12:17 PM

LGTM

test/ELF/lto/sample-profile.ll
5 ↗(On Diff #153751)

Remove this line.

This revision is now accepted and ready to land.Jul 2 2018, 12:17 PM
This revision was automatically updated to reflect the committed changes.