[Compiler-rt][MIPS][Profile] Adding support for MIPS32/64

[mohit.bhakkad]

Summary

Changed cmake/config-ix.cmake to add support for different MIPS architectures: mips, mipsel, mips64, mips64el
In profile code there is no target based dependencies, so just enabling mips flag does the work.
Test results are added below.

[mohit.bhakkad]

Added support for different MIPS architectures: mips, mipsel, mips64

[mohit.bhakkad]

cmake/config-ix.cmake

82

Defination of CMake if(MATCHES) command is
if(<variable|string> MATCHES regex)

Which can be ambiguous because of regex as an operand.

Whereas for CMake if(STREQUAL) exact lexicographical comparison between left and right operand is done;
if(<variable|string> STREQUAL <variable|string>)

source: http://www.cmake.org/cmake/help/v3.0/command/if.html

[samsonov]

cmake/config-ix.cmake

101–108

Why not just write "mipsel|mips64el" ?

[mohit.bhakkad]

cmake/config-ix.cmake

101–108

Yes, I will change it, and thinking about using STREQUAL instead of MATCHES which will result in faster comparison.

[samsonov]

LGTM

[mohit.bhakkad]

I don't have commit access, can someone please commit it for me?

[dsanders]

Committed in r218866.

cmake/config-ix.cmake

foreach(arg ${ARGN})
     set(argstring "${argstring} ${arg}")
   endforeach()
   try_compile(CAN_TARGET_${arch} ${CMAKE_BINARY_DIR} ${SIMPLE_SOURCE}
               COMPILE_DEFINITIONS "${TARGET_${arch}_CFLAGS}"
               OUTPUT_VARIABLE TARGET_${arch}_OUTPUT
               CMAKE_FLAGS "-DCMAKE_EXE_LINKER_FLAGS:STRING=${argstring}")
   if(${CAN_TARGET_${arch}})
     list(APPEND COMPILER_RT_SUPPORTED_ARCH ${arch})
   elseif("${COMPILER_RT_TEST_TARGET_ARCH}" MATCHES "${arch}" OR
          "${arch}" STREQUAL "arm_android")
     # Bail out if we cannot target the architecture we plan to test.
     message(FATAL_ERROR "Cannot compile for ${arch}:\n${TARGET_${arch}_OUTPUT}")
   endif()
 endmacro()
 
 # Generate the COMPILER_RT_SUPPORTED_ARCH list.
 if(ANDROID)
   test_target_arch(arm_android "")
 else()
   if("${LLVM_NATIVE_ARCH}" STREQUAL "X86")
     if (NOT MSVC)
       test_target_arch(x86_64 ${TARGET_64_BIT_CFLAGS})
     endif()
     test_target_arch(i386 ${TARGET_32_BIT_CFLAGS})
   elseif("${LLVM_NATIVE_ARCH}" STREQUAL "PowerPC")
     test_target_arch(powerpc64 ${TARGET_64_BIT_CFLAGS})
   elseif("${LLVM_NATIVE_ARCH}" STREQUAL "Mips")
-    test_target_arch(mips "")
+    if("${COMPILER_RT_TEST_TARGET_ARCH}" MATCHES "mipsel|mips64el")
+      # regex for mipsel, mips64el                                                                                                                                                                                 
+      test_target_arch(mipsel ${TARGET_32_BIT_CFLAGS})
+      test_target_arch(mips64el ${TARGET_64_BIT_CFLAGS})
+    else()
+      test_target_arch(mips ${TARGET_32_BIT_CFLAGS})
+      test_target_arch(mips64 ${TARGET_64_BIT_CFLAGS})
+    endif()
   endif()
   # Build ARM libraries if we are configured to test on ARM
   if("${COMPILER_RT_TEST_TARGET_ARCH}" MATCHES "arm|aarch64")
     test_target_arch(arm "-march=armv7-a")
     test_target_arch(aarch64 "-march=armv8-a")
   endif()
 endif()
 
 # Takes ${ARGN} and puts only supported architectures in @out_var list.
 function(filter_available_targets out_var)
   set(archs)
   foreach(arch ${ARGN})
     list(FIND COMPILER_RT_SUPPORTED_ARCH ${arch} ARCH_INDEX)
     if(NOT (ARCH_INDEX EQUAL -1) AND CAN_TARGET_${arch})
       list(APPEND archs ${arch})
     endif()
   endforeach()
   set(${out_var} ${archs} PARENT_SCOPE)
 endfunction()
 
 # Arhcitectures supported by compiler-rt libraries.
 # FIXME: add arm_android here
 filter_available_targets(SANITIZER_COMMON_SUPPORTED_ARCH
-  x86_64 i386 powerpc64 arm aarch64 mips arm_android)
+  x86_64 i386 powerpc64 arm aarch64 mips mips64 mipsel mips64el arm_android)
 filter_available_targets(ASAN_SUPPORTED_ARCH
   x86_64 i386 powerpc64 arm mips arm_android)
 filter_available_targets(DFSAN_SUPPORTED_ARCH x86_64)
 filter_available_targets(LSAN_SUPPORTED_ARCH x86_64)
 # LSan common files should be available on all architectures supported
 # by other sanitizers (even if they build into dummy object files).
 filter_available_targets(LSAN_COMMON_SUPPORTED_ARCH
   ${SANITIZER_COMMON_SUPPORTED_ARCH})
 filter_available_targets(MSAN_SUPPORTED_ARCH x86_64)
-filter_available_targets(PROFILE_SUPPORTED_ARCH x86_64 i386 arm aarch64)
+filter_available_targets(PROFILE_SUPPORTED_ARCH x86_64 i386 arm mips mips64 mipsel mips64el aarch64)
 filter_available_targets(TSAN_SUPPORTED_ARCH x86_64)
 filter_available_targets(UBSAN_SUPPORTED_ARCH x86_64 i386 arm aarch64)
 
 if(ANDROID)
   set(OS_NAME "Android")
 else()
   set(OS_NAME "${CMAKE_SYSTEM_NAME}")
 endif()