Page MenuHomePhabricator

sdkie (Kumar Sukhani)
User

Projects

User does not belong to any projects.

User Details

User Since
Jun 19 2014, 2:13 AM (264 w, 6 d)

Recent Activity

May 24 2015

sdkie added a comment to D9650: [LLVM] [AArch64] [DFSan] Adding support of AArch64 for DFSan.

@kcc @pcc Did you got time to review DFSAN patches for ARM64?

May 24 2015, 12:05 PM
sdkie added a comment to D9701: [AArch64] [ASAN] Enabling ASAN for AArch64 Architecture.

@enefaim: Did you got time to test ASAN on Juno?

May 24 2015, 12:03 PM

May 16 2015

sdkie added a comment to D9649: [AArch64] [DFSan] Adding support of AArch64 for DFSan.

@kcc @pcc Did you got time to review my patches?

May 16 2015, 12:19 AM

May 12 2015

sdkie added a comment to D9701: [AArch64] [ASAN] Enabling ASAN for AArch64 Architecture.

Hi Kumar,

This seems to be the patch that was flying around to enable ASAN on AArch64. Which board have you tested it? We need it to work at least on a Juno, which is where our buildbot runs.

cheers,
--renato

May 12 2015, 5:04 AM
sdkie retitled D9701: [AArch64] [ASAN] Enabling ASAN for AArch64 Architecture from to [AArch64] [ASAN] Enabling ASAN for AArch64 Architecture.
May 12 2015, 4:03 AM
sdkie updated the diff for D9650: [LLVM] [AArch64] [DFSan] Adding support of AArch64 for DFSan.

Considering AArch64 has only 39 bit addressable.

May 12 2015, 3:51 AM
sdkie added a comment to D9649: [AArch64] [DFSan] Adding support of AArch64 for DFSan.

@rengolin

AAarch64 has only 39 addressable bits not like MIPS64 which has 40 addressable bits.

Not all AArch64 is 39bits, some are 42bits.

We had this discussion in the ASAN side, and allowing 42bits made it work on those machines while it didn't increase memory footprint that much for 39bits, so assuming 42 was preferred. If here we have the same case, I'd guess taking the same assumption would be the way to go.

May 12 2015, 3:41 AM
sdkie updated the diff for D9649: [AArch64] [DFSan] Adding support of AArch64 for DFSan.

AAarch64 has only 39 addressable bits not like MIPS64 which has 40 addressable bits.

May 12 2015, 3:27 AM

May 10 2015

sdkie updated D9650: [LLVM] [AArch64] [DFSan] Adding support of AArch64 for DFSan.
May 10 2015, 10:52 AM
sdkie retitled D9651: [Clang] [AArch64] [DFSan] Adding support of AArch64 for DFSan from to [Clang] [AArch64] [DFSan] Adding support of AArch64 for DFSan.
May 10 2015, 10:50 AM
sdkie retitled D9650: [LLVM] [AArch64] [DFSan] Adding support of AArch64 for DFSan from to [LLVM] [AArch64] [DFSan] Adding support of AArch64 for DFSan.
May 10 2015, 10:46 AM
sdkie updated subscribers of D9649: [AArch64] [DFSan] Adding support of AArch64 for DFSan.
May 10 2015, 10:30 AM
sdkie retitled D9649: [AArch64] [DFSan] Adding support of AArch64 for DFSan from to [AArch64] [DFSan] Adding support of AArch64 for DFSan.
May 10 2015, 10:30 AM

Jan 31 2015

sdkie committed rL227684: [asan][mips] Fix MIPS64 Asan mapping.
[asan][mips] Fix MIPS64 Asan mapping
Jan 31 2015, 2:45 AM
sdkie abandoned D5616: [lsan] [mips] adding support of lsan for mips64/mips64el arch.

please check http://reviews.llvm.org/D7013 for further updates on this patch

Jan 31 2015, 1:24 AM
sdkie updated subscribers of D7013: [LSan] [MIPS] adding support of LSan for mips64/mips64el arch.
Jan 31 2015, 1:21 AM
sdkie closed D6734: [asan][mips][compiler-rt] Fix MIPS64 Asan mapping.

http://reviews.llvm.org/rL227683

Jan 31 2015, 1:19 AM
sdkie committed rL227683: [asan][mips] Fix MIPS64 Asan mapping.
[asan][mips] Fix MIPS64 Asan mapping
Jan 31 2015, 1:15 AM

Dec 22 2014

sdkie added a comment to D5616: [lsan] [mips] adding support of lsan for mips64/mips64el arch.

@earthdok: did you got time to look at my new patch?
Actually I am going on a long holiday after couple of day, @mohit.bhakkad and @sagar will continue my work.

Dec 22 2014, 5:54 AM

Dec 19 2014

sdkie updated D6734: [asan][mips][compiler-rt] Fix MIPS64 Asan mapping.
Dec 19 2014, 1:00 AM
sdkie retitled D6734: [asan][mips][compiler-rt] Fix MIPS64 Asan mapping from to [asan][mips][compiler-rt] Fix MIPS64 Asan mapping.
Dec 19 2014, 12:40 AM

Dec 18 2014

sdkie updated the diff for D5616: [lsan] [mips] adding support of lsan for mips64/mips64el arch.

updated patch as per suggestions of earthdok

Dec 18 2014, 1:33 AM

Dec 15 2014

sdkie closed D6500: [UBSan][MIPS] Adding support of MIPS64 in UBSan testing.

closed by rL224242

Dec 15 2014, 2:55 AM
sdkie closed D6320: [UBSan][MIPS] Adding support for MIPS64.

closed by rL224239

Dec 15 2014, 1:23 AM

Dec 12 2014

sdkie closed D6461: [mips] [test] Enable COMPILER_RT_INCLUDE_TESTS for MIPS.

closed by rL224101

Dec 12 2014, 12:25 AM

Dec 11 2014

sdkie updated subscribers of D6610: [mips] Fix assertion on i128 addition/subtraction on MIPS64.
Dec 11 2014, 5:10 AM
sdkie updated the diff for D6461: [mips] [test] Enable COMPILER_RT_INCLUDE_TESTS for MIPS.
  • used std::string instead of char in lib/sanitizer_common/tests/sanitizer_printf_test.cc
  • fixed lib/sanitizer_common/tests/sanitizer_allocator_test.cc:384
Dec 11 2014, 5:04 AM

Dec 8 2014

sdkie updated subscribers of D5616: [lsan] [mips] adding support of lsan for mips64/mips64el arch.
Dec 8 2014, 3:51 AM
sdkie added inline comments to D6461: [mips] [test] Enable COMPILER_RT_INCLUDE_TESTS for MIPS.
Dec 8 2014, 3:49 AM
sdkie added a comment to D5616: [lsan] [mips] adding support of lsan for mips64/mips64el arch.

@earthdok: I am not sure if mips stores the value of pthread struct size anywhere the way x86 does to write a UNIT test for pthread struct size.
Btw why x86_64 is using the hard codes values, even though they have direct access to pthread structure size?

Dec 8 2014, 2:55 AM
sdkie updated the diff for D5616: [lsan] [mips] adding support of lsan for mips64/mips64el arch.

updated TLS part after studying Glibc code

Dec 8 2014, 1:23 AM

Dec 7 2014

sdkie added a comment to D6459: [DFSAN][MIPS][LLVM] Defining ShadowPtrMask variable for MIPS64.
In D6459#16, @pcc wrote:

FYI, I needed to fix a test failure in r223536. Please make sure to test your changes before sending them for review.

Dec 7 2014, 10:54 PM

Dec 4 2014

sdkie updated the diff for D6461: [mips] [test] Enable COMPILER_RT_INCLUDE_TESTS for MIPS.

updated patch as per suggestions of @samsonov

Dec 4 2014, 10:12 PM
sdkie added a comment to D6437: [DFSAN][MIPS] adding support of DFSAN for MIPS64.

@pcc: I don't have commit access.
Can you commit both the patches for me?

Dec 4 2014, 9:57 PM
sdkie updated the diff for D6459: [DFSAN][MIPS][LLVM] Defining ShadowPtrMask variable for MIPS64.

added report_fatal_error for unsupported targets.

Dec 4 2014, 3:49 AM

Dec 3 2014

sdkie added inline comments to D6459: [DFSAN][MIPS][LLVM] Defining ShadowPtrMask variable for MIPS64.
Dec 3 2014, 1:05 AM

Dec 2 2014

sdkie updated the diff for D6461: [mips] [test] Enable COMPILER_RT_INCLUDE_TESTS for MIPS.
  • Introduced new CMake variable 'SANITIZER_TEST_SUPPORTED_ARCH'
  • Fixed Printf.Basic Test
Dec 2 2014, 1:03 AM

Dec 1 2014

sdkie retitled D6461: [mips] [test] Enable COMPILER_RT_INCLUDE_TESTS for MIPS from to [mips] [test] Enable COMPILER_RT_INCLUDE_TESTS for MIPS.
Dec 1 2014, 5:49 AM
sdkie retitled D6459: [DFSAN][MIPS][LLVM] Defining ShadowPtrMask variable for MIPS64 from to [DFSAN][MIPS][LLVM] Defining ShadowPtrMask variable for MIPS64.
Dec 1 2014, 3:39 AM

Nov 27 2014

sdkie updated the diff for D6437: [DFSAN][MIPS] adding support of DFSAN for MIPS64.

corrected 'kAppAddr' value

Nov 27 2014, 5:02 AM
sdkie updated subscribers of D6437: [DFSAN][MIPS] adding support of DFSAN for MIPS64.
Nov 27 2014, 4:55 AM
sdkie retitled D6437: [DFSAN][MIPS] adding support of DFSAN for MIPS64 from to [DFSAN][MIPS] adding support of DFSAN for MIPS64.
Nov 27 2014, 4:54 AM

Nov 24 2014

sdkie added a comment to D5616: [lsan] [mips] adding support of lsan for mips64/mips64el arch.

I am using following commands:

Nov 24 2014, 9:29 AM

Nov 22 2014

sdkie added a comment to D5616: [lsan] [mips] adding support of lsan for mips64/mips64el arch.

@earthdok: can you share your configure and build commands/scripts ?
So that I can get those test cases running.

Nov 22 2014, 8:52 AM

Nov 21 2014

sdkie added a comment to D5616: [lsan] [mips] adding support of lsan for mips64/mips64el arch.

Yeah, this doesn't look right. In your log it runs only the LIT tests from compiler-rt/test/sanitizer_common/.

Nov 21 2014, 9:52 AM

Nov 20 2014

sdkie added a comment to D5616: [lsan] [mips] adding support of lsan for mips64/mips64el arch.

What commands do you use to configure and build?

CC=clang CXX=clang++  cmake ../compiler-rt -DLLVM_CONFIG_PATH=/home/kms/LLVM_x86/install/bin/llvm-config  -DCOMPILER_RT_INSTALL_PATH=/home/kms/LLVM_x86/install/lib/clang/3.6.0
make install
make check-all
Nov 20 2014, 9:55 PM
sdkie added a comment to D5616: [lsan] [mips] adding support of lsan for mips64/mips64el arch.

Something must be wrong with your checkout. For me ninja check-sanitizer starts failing when I reverse the assertions in the test.

Nov 20 2014, 11:23 AM
sdkie added a comment to D5616: [lsan] [mips] adding support of lsan for mips64/mips64el arch.

And compiler-rt master build is not clean, I am getting following failures on x86_64:

Nov 20 2014, 5:00 AM
sdkie added a comment to D5616: [lsan] [mips] adding support of lsan for mips64/mips64el arch.

@earthdok: with check-sanitizer also I see no failures because of above changes in assertion.

Nov 20 2014, 4:29 AM

Nov 19 2014

sdkie added a comment to D5616: [lsan] [mips] adding support of lsan for mips64/mips64el arch.

I doubt whether its really working.
Even after doing following change 'make check-lsan' is working fine on x86_64

Nov 19 2014, 5:28 AM

Nov 18 2014

sdkie added a comment to D5616: [lsan] [mips] adding support of lsan for mips64/mips64el arch.

Also, please take note of test/asan/lit.cfg and test/asan/Unit/lit.site.cfg.in. Those configs enable leak detection in ASan tests on x86_64. Please make sure that is the case for MIPS as well.

Nov 18 2014, 3:19 AM

Nov 14 2014

sdkie added inline comments to D5616: [lsan] [mips] adding support of lsan for mips64/mips64el arch.
Nov 14 2014, 2:51 AM
sdkie updated the diff for D5616: [lsan] [mips] adding support of lsan for mips64/mips64el arch.

minor fixes as per comment of earthdok

Nov 14 2014, 2:35 AM

Nov 13 2014

sdkie updated the test plan for D5616: [lsan] [mips] adding support of lsan for mips64/mips64el arch.
Nov 13 2014, 2:52 AM
sdkie updated the diff for D5616: [lsan] [mips] adding support of lsan for mips64/mips64el arch.

using SanitizerAllocator32 instead of SanitizerAllocator64 for mips64 as its address space is just 40-bit

Nov 13 2014, 2:39 AM

Nov 12 2014

sdkie added a comment to D6024: [asan] [mips] added support of asan for mips64/mips64el.

Sorry for that mistake.
I will make sure my patch doesn't break anything on x86_64.

Nov 12 2014, 10:17 PM
sdkie added a comment to D6024: [asan] [mips] added support of asan for mips64/mips64el.

The output of malloc_loop.cc:
...
Allocated 16777216 chunks of 24 bytes, total 384 Mb
Allocated 33554432 chunks of 24 bytes, total 768 Mb
Allocated 67108864 chunks of 24 bytes, total 1536 Mb
Killed

Nov 12 2014, 4:14 AM
sdkie updated the diff for D6024: [asan] [mips] added support of asan for mips64/mips64el.

using SanitizerAllocator32 instead of SanitizerAllocator64 for mips64 as its address space is just 40-bit

Nov 12 2014, 1:42 AM

Nov 11 2014

sdkie planned changes to D5616: [lsan] [mips] adding support of lsan for mips64/mips64el arch.

@kcc @earthdok: any comments on current revision ?
I will soon update this revision to change SanitizerAllocator64 to SanitizerAllocator32.

Nov 11 2014, 10:12 PM

Nov 10 2014

sdkie added a comment to D6024: [asan] [mips] added support of asan for mips64/mips64el.

I got same output as you posted above. I tested it on mips64.

Nov 10 2014, 1:29 AM

Nov 7 2014

sdkie updated D6024: [asan] [mips] added support of asan for mips64/mips64el.
Nov 7 2014, 6:55 AM
sdkie updated the test plan for D5616: [lsan] [mips] adding support of lsan for mips64/mips64el arch.
Nov 7 2014, 6:06 AM
sdkie updated the diff for D5616: [lsan] [mips] adding support of lsan for mips64/mips64el arch.
  • updated TLS addr and size
  • introduced SANITIZER_POINTER_FORMAT_LENGTH variable
Nov 7 2014, 6:00 AM
sdkie retitled D6165: [asan] [llvm] [mips] adding ShadowOffset64 for mips64 from to [asan] [llvm] [mips] adding ShadowOffset64 for mips64.
Nov 7 2014, 5:41 AM
sdkie added a comment to D6024: [asan] [mips] added support of asan for mips64/mips64el.

@kcc: with top command I can see that address sanitized application can allocate VIRT(virtual memory) upto 1TB before exiting .

Nov 7 2014, 12:35 AM

Nov 6 2014

sdkie added a comment to D6024: [asan] [mips] added support of asan for mips64/mips64el.

@kcc: As mentioned here[1], whether 16TB of memory is must for asan64 ?
Because test-cases in compiler-rt are working fine.
Now I am planning to build some big application with asan which require GBs of memory.

Nov 6 2014, 5:27 AM
sdkie updated the diff for D6024: [asan] [mips] added support of asan for mips64/mips64el.

added SANITIZER_POINTER_FORMAT_LENGTH variable

Nov 6 2014, 4:50 AM

Nov 4 2014

sdkie updated subscribers of D4453: [compiler-rt][builtins][MIPS] Add test-cases for mips16 wrappers for float arithmetic, comparison & conversion.
Nov 4 2014, 3:16 AM
sdkie updated subscribers of D4454: [compiler-rt][builtins][MIPS] Add mips16 wrappers for float arithmetic, comparison and conversion.
Nov 4 2014, 3:16 AM
sdkie updated the diff for D6025: [asan] [mips] changed ShadowOffset32 for systems having 16kb PageSize.

increased the patch context using -U999999

Nov 4 2014, 12:59 AM
sdkie updated the diff for D6025: [asan] [mips] changed ShadowOffset32 for systems having 16kb PageSize.

Change "Default Linux/MIPS mapping" as commented by kcc

Nov 4 2014, 12:54 AM

Nov 3 2014

sdkie updated D6025: [asan] [mips] changed ShadowOffset32 for systems having 16kb PageSize.
Nov 3 2014, 3:31 AM
sdkie retitled D6080: [asan] [mips] [llvm] changed ShadowOffset32 for systems having 16kb PageSize from to [asan] [mips] [llvm] changed ShadowOffset32 for systems having 16kb PageSize.
Nov 3 2014, 3:28 AM

Oct 30 2014

sdkie added a comment to D6025: [asan] [mips] changed ShadowOffset32 for systems having 16kb PageSize.

Thanks.
Similar change need to be done in llvm code, I will submit its patch tomorrow.

Oct 30 2014, 11:15 AM

Oct 29 2014

sdkie added a reviewer for D6024: [asan] [mips] added support of asan for mips64/mips64el: earthdok.
Oct 29 2014, 6:09 AM
sdkie retitled D6025: [asan] [mips] changed ShadowOffset32 for systems having 16kb PageSize from to [asan] [mips] changed ShadowOffset32 for systems having 16kb PageSize.
Oct 29 2014, 5:55 AM
sdkie updated subscribers of D6024: [asan] [mips] added support of asan for mips64/mips64el.
Oct 29 2014, 5:25 AM
sdkie retitled D6024: [asan] [mips] added support of asan for mips64/mips64el from to [asan] [mips] added support of asan for mips64/mips64el.
Oct 29 2014, 5:24 AM
sdkie added a comment to D5616: [lsan] [mips] adding support of lsan for mips64/mips64el arch.

Which tests are failing and why?

Oct 29 2014, 2:14 AM

Oct 28 2014

sdkie updated the diff for D5616: [lsan] [mips] adding support of lsan for mips64/mips64el arch.

changed 'AppendPointer' function to print 40 bits for mips64 instead of 48 bits

Oct 28 2014, 5:26 AM
sdkie added a comment to D5616: [lsan] [mips] adding support of lsan for mips64/mips64el arch.

How did you test this patch?

Oct 28 2014, 2:50 AM
sdkie updated the diff for D5616: [lsan] [mips] adding support of lsan for mips64/mips64el arch.

minor fixes as per comments of earthdok

Oct 28 2014, 2:37 AM

Oct 20 2014

sdkie updated the diff for D5616: [lsan] [mips] adding support of lsan for mips64/mips64el arch.

minor change in CanBeAHeapPointer, the virtual addressable bits for mips are 40 and not 39

Oct 20 2014, 11:50 PM

Oct 15 2014

sdkie added a comment to D5616: [lsan] [mips] adding support of lsan for mips64/mips64el arch.

@earthdok: whether we should check for 'mips64' instead of 'mips' as we are anyways not supporting 32-bit mips for LSAN?

Oct 15 2014, 6:03 AM
sdkie added inline comments to D5616: [lsan] [mips] adding support of lsan for mips64/mips64el arch.
Oct 15 2014, 1:38 AM

Oct 14 2014

sdkie updated the diff for D5616: [lsan] [mips] adding support of lsan for mips64/mips64el arch.

made changes for 64-bit MIPS architectures

Oct 14 2014, 11:59 PM
sdkie updated subscribers of D5750: [UBSan] [MIPS] Adding support of UBSan for mipsel arch .
Oct 14 2014, 3:26 AM

Oct 10 2014

sdkie added a comment to D5616: [lsan] [mips] adding support of lsan for mips64/mips64el arch.

@pcc: I tried DFSAN for 32-bit MIPS and got 5 test cases pass out of 7.
Any plans to accept 32-bit DFSAN patches ?

Oct 10 2014, 1:02 AM
sdkie updated subscribers of D5616: [lsan] [mips] adding support of lsan for mips64/mips64el arch.
Oct 10 2014, 12:29 AM
sdkie added a comment to D5616: [lsan] [mips] adding support of lsan for mips64/mips64el arch.

It will be great if someone will add this details on http://compiler-rt.llvm.org.

Oct 10 2014, 12:12 AM
sdkie added a comment to D5615: [asan] [mips] adding support of asan for mipsel arch.

samsonov: can you commit it for me ?
I don't have commit access.

Oct 10 2014, 12:03 AM

Oct 9 2014

sdkie planned changes to D5616: [lsan] [mips] adding support of lsan for mips64/mips64el arch.

Thanks for your comments. I will try to update the patch for MIPS64.
Few people are also working on 32-bit MSAN and 32-bit TSAN for MIPS.
can anyone please comment on them, as we don't see i386 implementation of those sanitizers also.

Oct 9 2014, 12:20 AM

Oct 8 2014

sdkie updated the diff for D5615: [asan] [mips] adding support of asan for mipsel arch.

merged CAN_TARGET_mips and CAN_TARGET_mipsel

Oct 8 2014, 11:56 PM

Oct 4 2014

sdkie retitled D5616: [lsan] [mips] adding support of lsan for mips64/mips64el arch from to [lsan] [mips] adding support of lsan for mips/mipsel arch.
Oct 4 2014, 12:42 AM
sdkie updated subscribers of D5615: [asan] [mips] adding support of asan for mipsel arch.
Oct 4 2014, 12:33 AM
sdkie retitled D5615: [asan] [mips] adding support of asan for mipsel arch from to [asan] [mips] adding support of asan for mipsel arch.
Oct 4 2014, 12:33 AM

Jun 23 2014

sdkie updated subscribers of D4251: [compiler-rt][builtins] CTest to execute builtins testsuite.
Jun 23 2014, 3:04 AM

Jun 22 2014

sdkie added a comment to D4208: [asan] adding support of 32-bit address sanitizer for MIPS.
In D4208#12, @dsanders wrote:

Hi Kumar,

Do you have commit access? If not, I'm happy to commit it for you.

Jun 22 2014, 10:43 PM
sdkie added a comment to D4208: [asan] adding support of 32-bit address sanitizer for MIPS.
In D4208#10, @petarj wrote:

Unexpected Failures: 19

Can you list these tests? Why do they fail?

Jun 22 2014, 10:41 PM

Jun 19 2014

sdkie retitled D4208: [asan] adding support of 32-bit address sanitizer for MIPS from to [asan] adding support of 32-bit address sanitizer for MIPS.
Jun 19 2014, 3:51 AM