This patch removes on optimization used with the TRUE/FALSE
predicates, as was suggested in https://reviews.llvm.org/D45616
for r335339.
The optimization was buggy, since r335339 used it also
for *_mask builtins, without actually applying the mask -- the
mask argument was just ignored.
Details
Diff Detail
- Repository
- rC Clang
- Build Status
Buildable 19819 Build 19819: arc lint + arc unit
Event Timeline
test/CodeGen/avx-builtins.c | ||
---|---|---|
1423 | Why are we deleting tests instead of replacing the CHECK lines with the new output? |
test/CodeGen/avx-builtins.c | ||
---|---|---|
1423 | These cases were only added, when the TRUE/FALSE related special cases were added in CGBuiltin.cpp. Now that the special cases are removed from CGBuiltin.cpp, it seemed consistent to also remove the related special cases from the tests, as these are not special anymore. |
test/CodeGen/avx-builtins.c | ||
---|---|---|
1423 | Yes. IIUC, we would have caught the bug before it was committed if we had proper tests for each predicate and C intrinsic. |
test/CodeGen/avx-builtins.c | ||
---|---|---|
1423 | That is true! |
Why are we deleting tests instead of replacing the CHECK lines with the new output?