Page MenuHomePhabricator

uriel.k (Uriel Korach)
User

Projects

User does not belong to any projects.

User Details

User Since
Sep 7 2017, 1:47 AM (97 w, 2 d)

Recent Activity

Mar 25 2018

uriel.k added a comment to D41599: [X86] Lowering X86 avx512 sqrt intrinsics to IR - LLVM.

@uriel.k Sorry, this patch and D41168 fell off my radar for a while - are you still looking at this?

Mar 25 2018, 7:50 AM

Jan 15 2018

uriel.k added a comment to D41599: [X86] Lowering X86 avx512 sqrt intrinsics to IR - LLVM.

Simon, is there anything else you think that is needed to be changed before accepting the revision?
Thanks

Jan 15 2018, 1:22 AM

Jan 1 2018

uriel.k added a comment to D41599: [X86] Lowering X86 avx512 sqrt intrinsics to IR - LLVM.

Won't this mean that explicit calls to the SSE sqrt intrinsics may be converted to the rsqrt+NR estimates in some cases?

Jan 1 2018, 1:17 AM
uriel.k updated the diff for D41599: [X86] Lowering X86 avx512 sqrt intrinsics to IR - LLVM.
Jan 1 2018, 1:12 AM
uriel.k committed rL321619: [X86] Regenerate test checks in sse-intrinsics-x86-upgrade with update-llc.
[X86] Regenerate test checks in sse-intrinsics-x86-upgrade with update-llc
Jan 1 2018, 1:01 AM
uriel.k committed rL321618: [X86] Regenerate test checks in sse2-intrinsics-x86-upgrade with update-llc.
[X86] Regenerate test checks in sse2-intrinsics-x86-upgrade with update-llc
Jan 1 2018, 12:49 AM

Dec 27 2017

uriel.k created D41599: [X86] Lowering X86 avx512 sqrt intrinsics to IR - LLVM.
Dec 27 2017, 6:57 AM
uriel.k updated the diff for D41168: [X86] Lowering X86 avx512 sqrt intrinsics to IR.

now takes care of sqrt with round mode CURR_DIRECTION

Dec 27 2017, 6:52 AM

Dec 13 2017

uriel.k created D41168: [X86] Lowering X86 avx512 sqrt intrinsics to IR.
Dec 13 2017, 3:50 AM

Nov 13 2017

uriel.k committed rL318036: [X86] test/testn intrinsics lowering to IR. llvm part..
[X86] test/testn intrinsics lowering to IR. llvm part.
Nov 13 2017, 4:52 AM
uriel.k closed D38736: [X86] test/testn intrinsics lowering to IR. llvm part. by committing rL318036: [X86] test/testn intrinsics lowering to IR. llvm part..
Nov 13 2017, 4:51 AM
uriel.k committed rL318035: [X86] test/testn intrinsics lowering to IR. clang side.
[X86] test/testn intrinsics lowering to IR. clang side
Nov 13 2017, 4:51 AM
uriel.k closed D38737: [X86] test/testn intrinsics lowering to IR. clang side by committing rL318035: [X86] test/testn intrinsics lowering to IR. clang side.
Nov 13 2017, 4:51 AM

Nov 8 2017

uriel.k added inline comments to D38737: [X86] test/testn intrinsics lowering to IR. clang side.
Nov 8 2017, 6:31 AM
uriel.k added inline comments to D38737: [X86] test/testn intrinsics lowering to IR. clang side.
Nov 8 2017, 6:29 AM
uriel.k updated the diff for D38737: [X86] test/testn intrinsics lowering to IR. clang side.
Nov 8 2017, 6:24 AM

Nov 6 2017

uriel.k updated the diff for D38737: [X86] test/testn intrinsics lowering to IR. clang side.
Nov 6 2017, 3:56 AM
uriel.k updated the diff for D38737: [X86] test/testn intrinsics lowering to IR. clang side.
Nov 6 2017, 1:52 AM
uriel.k updated the diff for D38736: [X86] test/testn intrinsics lowering to IR. llvm part..
Nov 6 2017, 1:41 AM
uriel.k committed rL317465: [X86][AVX512] Improve lowering of AVX512 test intrinsics.
[X86][AVX512] Improve lowering of AVX512 test intrinsics
Nov 6 2017, 1:23 AM
uriel.k closed D38732: [X86][AVX512] Improve lowering of AVX512 test intrinsics by committing rL317465: [X86][AVX512] Improve lowering of AVX512 test intrinsics.
Nov 6 2017, 1:23 AM
uriel.k committed rL317464: [X86] Replace duplicate function call with variable. NFC.
[X86] Replace duplicate function call with variable. NFC
Nov 6 2017, 12:33 AM

Oct 30 2017

uriel.k updated the diff for D38732: [X86][AVX512] Improve lowering of AVX512 test intrinsics.

Added the case of the pattern with X86::FAND. Hopefully this is the last update. Please let me know if there is something else I missed.

Oct 30 2017, 1:51 AM

Oct 15 2017

uriel.k updated the diff for D38736: [X86] test/testn intrinsics lowering to IR. llvm part..

Added fast-isel tests.
Note that for avx512bw there is an open bug that responsible for that huge code size.

Oct 15 2017, 4:37 AM
uriel.k added inline comments to D38732: [X86][AVX512] Improve lowering of AVX512 test intrinsics.
Oct 15 2017, 3:58 AM

Oct 11 2017

uriel.k updated the diff for D38732: [X86][AVX512] Improve lowering of AVX512 test intrinsics.

fixed requested changes by Simon and Craig and as you can see added the new test files to trunk as NFC commit and showed the diff.

Oct 11 2017, 2:16 AM
uriel.k committed rL315443: [X86] Added tests for TESTM and TESTNM (NFC).
[X86] Added tests for TESTM and TESTNM (NFC)
Oct 11 2017, 1:39 AM
uriel.k added a comment to D38732: [X86][AVX512] Improve lowering of AVX512 test intrinsics.

Add the new test files to trunk with current codegen and then rebase to show the diff from this patch.

Oct 11 2017, 12:35 AM

Oct 10 2017

uriel.k updated the summary of D38736: [X86] test/testn intrinsics lowering to IR. llvm part..
Oct 10 2017, 8:11 AM
uriel.k created D38737: [X86] test/testn intrinsics lowering to IR. clang side.
Oct 10 2017, 8:11 AM
uriel.k created D38736: [X86] test/testn intrinsics lowering to IR. llvm part..
Oct 10 2017, 8:06 AM
uriel.k added inline comments to D38732: [X86][AVX512] Improve lowering of AVX512 test intrinsics.
Oct 10 2017, 7:32 AM
uriel.k created D38732: [X86][AVX512] Improve lowering of AVX512 test intrinsics.
Oct 10 2017, 7:28 AM
uriel.k closed D38689: [X86] Fix a bug with i386 subtarget in LowerCONCAT_VECTORSvXi1 func.

Committed in rL315311. Sorry for the poor commit message, added a suitable message in comment in https://reviews.llvm.org/rL315311

Oct 10 2017, 6:58 AM
uriel.k added a comment to rL315311: after fixing the i386 case.

Sorry for the poor commit message. Should have been:

Oct 10 2017, 6:54 AM
uriel.k committed rL315311: after fixing the i386 case.
after fixing the i386 case
Oct 10 2017, 6:43 AM
uriel.k updated the diff for D38689: [X86] Fix a bug with i386 subtarget in LowerCONCAT_VECTORSvXi1 func.

Changed function to be DAG.getIntPtrConstant(0, dl) instead.

Oct 10 2017, 3:33 AM

Oct 9 2017

uriel.k created D38689: [X86] Fix a bug with i386 subtarget in LowerCONCAT_VECTORSvXi1 func.
Oct 9 2017, 8:20 AM

Sep 26 2017

uriel.k committed rL314195: [X86] Finishing broadcastf32x2 and broadcasti32x2 intrinsics lowering to IR..
[X86] Finishing broadcastf32x2 and broadcasti32x2 intrinsics lowering to IR.
Sep 26 2017, 3:33 PM
uriel.k closed D38220: [X86] Finishing broadcast[f|i]32x2 intrinsics lowering to IR..

committed in 314195

Sep 26 2017, 3:30 PM

Sep 25 2017

uriel.k updated the diff for D38220: [X86] Finishing broadcast[f|i]32x2 intrinsics lowering to IR..

change after Michael comment

Sep 25 2017, 5:03 AM
uriel.k created D38220: [X86] Finishing broadcast[f|i]32x2 intrinsics lowering to IR..
Sep 25 2017, 5:03 AM

Sep 13 2017

uriel.k closed D37693: [X86] [PATCH] [intrinsics] Lowering X86 ABS intrinsics to IR. (llvm).

committed in rL313134

Sep 13 2017, 3:36 AM
uriel.k committed rL313134: [X86] [PATCH] [intrinsics] Lowering X86 ABS intrinsics to IR. (llvm).
[X86] [PATCH] [intrinsics] Lowering X86 ABS intrinsics to IR. (llvm)
Sep 13 2017, 2:04 AM
uriel.k committed rL313133: [X86] [PATCH] [intrinsics] Lowering X86 ABS intrinsics to IR. (clang).
[X86] [PATCH] [intrinsics] Lowering X86 ABS intrinsics to IR. (clang)
Sep 13 2017, 2:03 AM
uriel.k closed D37694: [X86] [PATCH] [intrinsics] Lowering X86 ABS intrinsics to IR. (clang) by committing rL313133: [X86] [PATCH] [intrinsics] Lowering X86 ABS intrinsics to IR. (clang).
Sep 13 2017, 2:03 AM
uriel.k committed rL313131: [X86] Add explicit mc-encoding checks to X86/viabs.ll. NFC..
[X86] Add explicit mc-encoding checks to X86/viabs.ll. NFC.
Sep 13 2017, 1:35 AM
uriel.k closed D37688: [X86] Add explicit mc-encoding checks to X86/viabs.ll. NFC. by committing rL313131: [X86] Add explicit mc-encoding checks to X86/viabs.ll. NFC..
Sep 13 2017, 1:35 AM

Sep 12 2017

uriel.k updated the diff for D37693: [X86] [PATCH] [intrinsics] Lowering X86 ABS intrinsics to IR. (llvm).

Updated IR code in avx2-intrinsics-fast-isel.ll and ssse3-intrinsics-fast-isel.ll (figured this file should also be updated) to have the IR code generated from clang for the ABS intrinsics instead of the intrinsics' calls.

Sep 12 2017, 1:30 AM
uriel.k added a comment to D37694: [X86] [PATCH] [intrinsics] Lowering X86 ABS intrinsics to IR. (clang).

If I remove the builtins from the .def file this will not work, as I didn't replace the builtin call in the Header files but implemented the lowering by adding cases to the CGBuiltin.cpp and adding the IR by hand. Correct me if I'm wrong about this.

Sep 12 2017, 12:15 AM

Sep 11 2017

uriel.k retitled D37693: [X86] [PATCH] [intrinsics] Lowering X86 ABS intrinsics to IR. (llvm) from [X86] [PATCH] [intrinsics] Lowering X86 ABS intrinsics to IR. to [X86] [PATCH] [intrinsics] Lowering X86 ABS intrinsics to IR. (llvm).
Sep 11 2017, 8:15 AM
uriel.k created D37694: [X86] [PATCH] [intrinsics] Lowering X86 ABS intrinsics to IR. (clang).
Sep 11 2017, 8:15 AM
uriel.k created D37693: [X86] [PATCH] [intrinsics] Lowering X86 ABS intrinsics to IR. (llvm).
Sep 11 2017, 8:09 AM
uriel.k created D37688: [X86] Add explicit mc-encoding checks to X86/viabs.ll. NFC..
Sep 11 2017, 7:29 AM

Sep 10 2017

uriel.k committed rL312880: Revert "adding autoUpgrade support to broadcast[f|i]32x2 intrinsics".
Revert "adding autoUpgrade support to broadcast[f|i]32x2 intrinsics"
Sep 10 2017, 2:08 AM
uriel.k committed rL312879: adding autoUpgrade support to broadcast[f|i]32x2 intrinsics.
adding autoUpgrade support to broadcast[f|i]32x2 intrinsics
Sep 10 2017, 1:41 AM
uriel.k committed rL312878: Test commit.
Test commit
Sep 10 2017, 1:32 AM